[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Dmytro Prokopchuk1 <dmytro_prokopchuk1@xxxxxxxx>
- Date: Thu, 10 Jul 2025 09:47:50 +0000
- Accept-language: en-US, uk-UA, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ThUFovPB56FkSfslnPvJ173MNG+V8jeZ/6O7eP9x42A=; b=kBpCxP6CEpB90GY+nJf71b7aaFqdLEbDyB070F7qtwL+m8CpYoMO59bo7KRBThj32SgFpVPdC6BHhFzrt5qpc31bYMCOrNC/+fVoqyutf2DtMG/rpckw7MGEW7HSF3uycqTCvVkKviyNkq0J41xRTcbj5Bd/+IncvpkIa8Y2jJ3gbjd+6bLtbTQSjLrDIe3xf9nWrrPby8JQmHX85zCHfJ6isIZCVRLziwfY0JF47TdGQM9I02wnsMn3qMYxGnYUNHJoZ2RVM0sFKdWOcLGsqNd2Y7yGJGnQvD+n6gRzMHC5jtccgTOumRjaDFq33WoCtEvgcLW120PkGqk8z+NCgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KMoOLF0Nc2pti//SeSOaqwlamb41jH9eapvai3ExOCRnBjOLvDkUG54WboveetENEHTBkfX3XOrGMUe8iGrJdlHRxeTxkxfo2vKnOoU8adV2rcT1OI+reOwUyLMbMXrni6XNynQT3grYbwCCBOKB90Co2cRISz34k8I+D3HFvqlqJc9i5LTdxAYlhqUj9J+Oo1YoFsqFj9n9hDs7d1xosmWczI458PQ3YGyTHDd6tJXeJgBauB1axgTXK1I0OO+xJRpbfFsVucEq9taRiMHmdNUh8PfqRd/q+k/a3j1+hyE+0j7bEAvB773vgUoXlRqtgIshSuIPS4IDHePccYI7aA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Jul 2025 09:48:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHb8RnHknh9PmNpckO7ne8U6W29yLQrBRIAgAAXOYCAAADmAA==
- Thread-topic: [XEN PATCH v2 1/3] iommu: address violation of MISRA C Rule 5.5
Jan, I don't mind, you can adjust it.
Please, go ahead.
On 7/10/25 12:44, Dmytro Prokopchuk wrote:
> Yes, sure. I'll update commit message.
> Thanks!
>
> On 7/10/25 11:21, Jan Beulich wrote:
>> On 09.07.2025 23:38, Dmytro Prokopchuk1 wrote:
>>> Address a violation of MISRA C:2012 Rule 5.5:
>>> "Identifiers shall be distinct from macro names".
>>>
>>> Reports for service MC3A2.R5.5:
>>> xen/drivers/passthrough/iommu.c: non-compliant macro 'iommu_quarantine'
>>> xen/include/xen/iommu.h: non-compliant variable 'iommu_quarantine'
>>>
>>> There is a clash between function name and macro.
>>> Add an 'extern' declaration for 'iommu_quarantine'
>>> under the same preprocessor condition (#ifdef CONFIG_HAS_PCI).
>>
>> Perhaps s/Add an/Put the/ or some such? You don't add any declaration,
>> after all.
>>
>>> This ensures that the declaration is consistent
>>> and only exposed when CONFIG_HAS_PCI is defined.
>>>
>>> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopchuk1@xxxxxxxx>
>>
>> With some suitable adjustment (happy to make while committing as long as
>> you agree):
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> Jan
>
|
