Re: [PATCH v6] automation/eclair: update configuration of D4.10

["Anthony PERARD" <anthony.perard@xxxxxxxxxx>]

On Mon, Jun 23, 2025 at 06:19:27PM -0700, Stefano Stabellini wrote:
> diff --git a/xen/include/xen/compile.h.in b/xen/include/xen/compile.h.in
> index 3151d1e7d1..9206341ba6 100644
> --- a/xen/include/xen/compile.h.in
> +++ b/xen/include/xen/compile.h.in
> @@ -1,3 +1,6 @@
> +#ifndef XEN_COMPILE_H
> +#define XEN_COMPILE_H
> +
>  #define XEN_COMPILE_DATE     "@@date@@"
>  #define XEN_COMPILE_TIME     "@@time@@"
>  #define XEN_COMPILE_BY               "@@whoami@@"
> diff --git a/xen/tools/process-banner.sed b/xen/tools/process-banner.sed
> index 56c76558bc..4cf3f9a116 100755
> --- a/xen/tools/process-banner.sed
> +++ b/xen/tools/process-banner.sed
> @@ -12,3 +12,8 @@ s_(.*)_"\1\\n"_
>  
>  # Trailing \ on all but the final line.
>  $!s_$_ \\_
> +
> +# Append closing header guard
> +$a\
> +\
> +#endif /* XEN_COMPILE_H */

Is it wise to put the closing header guard in a file call
"process-banner" ? It's not call compile.h-footer.sed.

There's a few way to make this better:
- simple add the header guard from the Makefile, both opening and
  closing.
- Do some more sed with something like:
  sed -rf process-banner.sed < .banner >> .banner.processed.tmp
  sed -e 's/@@date@@/$(XEN_BUILD_DATE)/g' \
      ... \
      -e '/XEN_BANNER/r .banner.processed.tmp'
  # and having the closing header guard in "compile.h.in"
  This will add the outpot of process-banner.sed in the lines after
  "#define XEN_BANNER", and so before the closing header guard.
- rename the sed command file
(- a forth option would be to use filechk make macro, but the check for
 if [ ! -r $@ -o -O $@ ] would be annoying to reproduce.)

Another thing, this could be done in a patch that isn't called
"automation/eclair: update configuration of D4.10".

Cheers,

-- 

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech