Re: [PATCH v3 17/22] x86/acpi: disallow S3 on Secure Launch boot

[Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>]

On Wed, Jul 02, 2025 at 04:48:38PM +0200, Jan Beulich wrote:
> On 30.05.2025 15:17, Sergii Dmytruk wrote:
> > @@ -356,6 +357,13 @@ int acpi_enter_sleep(const struct 
> > xenpf_enter_acpi_sleep *sleep)
> >             PAGE_SIZE - acpi_sinfo.vector_width / 8)) )
> >          return -EOPNOTSUPP;
> >
> > +    /* Secure Launch won't initiate DRTM on S3 resume, so abort S3 
> > suspend. */
> > +    if ( sleep->sleep_state == ACPI_STATE_S3 && slaunch_active )
> > +    {
> > +        printk(XENLOG_INFO "SLAUNCH: refusing switching into ACPI S3 
> > state.\n");
> > +        return -EPERM;
>
> Not sure about the error code here: Generally we prefer to limit EPERM to
> what XSM has to say. Could I talk you into using e.g. EACCES instead?
>
> Jan

I have nothing against EACCES.  I went with EPERM because I saw it
being used twice in this function.

Regards