[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/2] xen/console: unify printout behavior for UART emulators



On 28/06/2025 18:26, Julien Grall wrote:
Hi Stefano,

On 21/06/2025 01:52, Stefano Stabellini wrote:
Widely used or not - _I_ use it all the time in debug configs where serial
is available.

Fair enough and your usage is really important for the project. At the
same time you know exactly what's going on so you wouldn't be confused
by the presence or absence of a (d0) prefix.

The main issue is when less familiar users try Xen, or less familiar
developers go through the Xen source code to learn from it.

I would optimize this choice to make it simpler for users and to make
the code simpler. Your use-case is really important as well, but I would
trust you to understand what's going on either way, with or without the
(d0) prefix.

Thanks for the clarification. I gave a try with and without the series to understand a bit more the difference. I think there are some imbalance in that setup because when the focus is on Xen, the logs are still prefixed with "(XEN)". So naturally the log with no prefix are the one for Dom0. So I have to agree with Jan here.

I forgot to clarify, this is not an ask to remove (XEN) when the focus is on Xen. This is more we should keep the existing behavior.

Cheers,

--
Julien Grall




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.