[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 3/4] xen/arm: Move make_resv_memory_node()
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Koichiro Den <den@xxxxxxxxxxxxx>
- Date: Sat, 28 Jun 2025 23:07:41 +0900
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgl5PQvJZ4OV4myipiXt+4l9Si8lphWW4NdCwHuCHO0=; b=EeZifzyc7NWnkDDZCeYd/NlK0NnhuMI6ZPcqRr39myI1KNgbY8B2+Q8bWroZ5xX1RHprUb0oLRJF1ZaDHe4avIWN05VvcMjoVU5yxn0myYJ4OK6h38pji3jzXDAlxsan5aaPq/CKDLpLZBNo5wF7M63WsK9dF/CpPN/R+pX0Zd0oiI/Hr4MOCH5n9SuwZuJeoqkTxXBP2TxGX4jDa7FsAXahyF5RxbfbRKyClMM3re+0Ei5XwYoGASwboOQnPSCRqc8Xx9fWnZtos2vAXNqz3zQaQbWt74lzVO03jocCk9qtTFNXPkdDLH8RA7jscn91mRcarocYzU47kVcnQ5FFMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v+LTDw3qjznyyj5Cyg2Y3KT6Kvo93gY0qynawumS/EdRc479XlxCNxhSYTl8W6LGmD7jFInZx3hJA5HZub5fyaSKaz0JMyIRUQsiy0ns9YYDEmKJfbOeK2utN6ahZpHadk+LhXtdW+zTuuyb9M1iLbuNhe0TSIdZxaQjO61w4F0Hb2cxhho0S9/DElbdkHnUmSURN5Oq3cMYVGyWSejrr8tXgzQXBfn3GPAegIXjQI2hupcssjYOgNogJe1odUHXV2T/7iq4pBGuP7dOgPSRtHevepRN3tnBGV7crNz3oz+NvA5REjTxlWke7HUt0CokpDMapx282hVjTQokM/t7bw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Sat, 28 Jun 2025 14:07:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sun, Jun 22, 2025 at 04:12:15PM -0700, Stefano Stabellini wrote:
> On Sun, 22 Jun 2025, Koichiro Den wrote:
> > The /reserved-memory node is inherently not specific to static-shmem. In
> > the next commit, child nodes will be added under /reserved-memory for
> > the stolen time shared memory regions.
> >
> > No functional changes intended.
> >
> > Signed-off-by: Koichiro Den <den@xxxxxxxxxxxxx>
>
> This causes a build failure when CONFIG_STATIC_SHM is missing.
>
> arch/arm/domain_build.c: In function ‘make_resv_memory_node’:
> arch/arm/domain_build.c:1567:34: error: implicit declaration of function
> ‘kernel_info_get_shm_mem_const’; did you mean ‘kernel_info_get_mem_const’?
> [-Werror=implicit-function-declaration]
> 1567 | const struct membanks *mem = kernel_info_get_shm_mem_const(kinfo);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | kernel_info_get_mem_const
> arch/arm/domain_build.c:1567:34: error: nested extern declaration of
> ‘kernel_info_get_shm_mem_const’ [-Werror=nested-externs]
> arch/arm/domain_build.c:1567:34: error: initialization of ‘const struct
> membanks *’ from ‘int’ makes pointer from integer without a cast
> [-Werror=int-conversion]
Thank you for pointing that out, I'll address this in v2.
>
---(snip)---
|
