[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] stubdom/grub: avoid relying on start_info definition
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Wed, 25 Jun 2025 09:25:48 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7PgfEBNTfs9tlqljiTqfK0ldvGQZopp+kEXzXSsVFMI=; b=hwjA95h6z9uCw/nac6YgNOniwV3JE5W+JhgjDWLnPSqcoeulv9mtZc2cvy/ByaWhyHj275NKzxQymdcvNbAOA9WKgEKnsKie5JUTJVbBn4Yvql15zqCLT+rxbzpgn+1G3+H8Wsl+P0Z+rHaNk/+yBIHdzgZ4PVX6eBhdhEqnXvnXz1eTJehErGcgaNZhfqr8XzKfYpwhoFO2MGxck8+zDMisKPaas0BPwYxlLFSZkZk0nd1hPoKe+/Jy5+fO+iZSWreHXLmEeb/VF0PxWKHDlaHHLi3Le1kfJFG5oaTQYNoLZFbnuKLr1AYtMbcRgXQ+zuvPOs/xABWAGGWDgVdRlw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LLnZDTFwgc9a+TdEd2YPIlOkZZbUu3hfkr6KqdMN1Yyr+2B1LnzozAX87O7UQLeFppOea/eQeprsqcp8FILGhYfSSwknkmUQTV1cFyfHwni744snFn88D8oepViIjNYL2rTm6fgagLjdWdpDacaZcu0OLEXy7WCZyUTkF7UA4H87Ux9OMNG8n0+5B2QhUpEAfwy6YcPCFLkqa7SWSTPWXCqT9Qo5l+R9tzWK51dT+Hs85IXNgOdcPQHomS4YBuDYBRA0iVcVD4ftgJS5/Dd6Cr/dhog3czza8zRsseuNz2h7+1Na4MrsSZxLkWRlEEmZA9Oe8erVlqmkb5DLlk4NMA==
- Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
- Delivery-date: Wed, 25 Jun 2025 13:25:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-06-25 07:08, Juergen Gross wrote:
The kexec() function of grub-pv is relying on the exact definition of
start_info from Mini-OS by having an "#undef start_info" and a few
lines later a copy of the Mini-OS definition again.
This is bad practice by making all attempts of Mini-OS to change that
definition impossible.
Avoid that dependency by moving the code fragment in question to the
very end of the source file, allowing to drop the copy of the
definition.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
