[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 04/16] arm/vpl011: use raw spin_lock_{irqrestore,irqsave}
- To: Jan Beulich <jbeulich@xxxxxxxx>, dmkhn@xxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 24 Jun 2025 09:50:54 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VWDtRws4wrWqUa64cyzxkSJG3FdUSmAv16KbKWqihU=; b=JId3wbYeRGWDbqPTZzEObquXAuIQOCIr2mSyx63RtbDwRV7gQGDBLJ/ugBxxNyGXbntbvjRg4amkjfnJ0PUyVo3Ea5YGcdY4TEgTwzfiN5V/HXaE7YJW6PXgWgM1haVTFGPe2BdrIPiSU5h+T4a0E9mwfkmEiKwC6G7Y+4IEGm4bp6pBfJgnluVwMHqTpN3E35f9Tp0eoG1o7Oopnvx/MGHjYpeEaRPSxT5MLitzWaSeztfIebeAIaObQBjfVTNM8fHRlxcG0z1vuXFgzMMIBMtokwLPAonG73tyaTrHRh6bnE/1rjdTDNDK9IE6JtITekrp/lbrnhRfmO19vghC7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FS9icDnXNoaOjAFAr6UtYY67iCKnkJiE9O9M7HRDB7sFSY7kSKQ0dqexq0C6qxrh2aZ5Hmh4EX3oIkU9F1vE8lVbRxR5uRV/UxoBpHuTvTbnFV+JmsM8DCoyDFqb4GlaXqS1RwH8haPWj1+D+Ooly9hUlr+IE479ae0XNYQ3poB1Qq3onfDcfl2n3YdP121tC+CerKKEae5oW0mcwHEzmAEE3dAHmKqIaQ2tpiGgoJfmXUVl5Ovw1WEx2BpwU6Ugu4i9cEsogSNkxPzvjZnOh9NE7v88r4tKT6Fo+AOd/AtF3E5LeS30aiBIX6bQeve/yPjciH/jZeztLkxDxNtX1Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, julien@xxxxxxx, oleksii.kurochko@xxxxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Jun 2025 07:51:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/06/2025 07:46, Jan Beulich wrote:
> On 24.06.2025 05:55, dmkhn@xxxxxxxxx wrote:
>> From: Denis Mukhin <dmukhin@xxxxxxxx>
>>
>> Replace VPL011_{LOCK,UNLOCK} macros with raw spinlock calls to improve
>> readability.
>
> I'm not an Arm maintainer, so I have limited say here, but: How is this
> improving readability? It better utilizes available local variables, yes,
> so this may be a little bit of an optimization, but otherwise to me this
> looks to rather hamper readability.
I agree with Jan here. I don't think it improves readability, therefore I don't
think such change is needed.
~Michal
|
