[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 07/16] arm/vuart: rename 'virtual UART' Kconfig option
- To: dmkhn@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 24 Jun 2025 08:37:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7HlwwAJT3wSwT9dOfKxVZ1LcxafB2aD3LX7acmr0LkE=; b=FkkM7/WlYwkZNAxVpmwXvlrRrdgV3GJND/bO+UfHcuhT5VicyTkNZRaaMo3ZIaXWiPjDyU4jWe62PEZMxq+i8w3SCD5qFD8EpSEPTapCv5kO+IPCL+ZPGv9hLYvtdMy2bKEbmZF2NKtxdZOKD4p1Ou+ZaW2Gc2+yo6gjEHQ/AnMyW0UPLS4oHa16fG77Q/Q4BktiVD62rFWBrJFU0584lUAE9suNRgxnrVT6lTXK2ar5/K8r5T/BOOpqH0K3zTVIUVkw1wfEu/ohwiBl1a30cHTGnO1rJp5SItpdjW3Sg1mDOPDCDrmcviwdaPvIS32fOz1NjZnEU+N8XK6fvXHZGQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hl48SLcpM1I5txA+rhu4MnJ2KHPiKhiFDkQU7gkra8LH7u9ZZJ4YMK6FXfaJry7HmTLVwECFXC0AONul5BslpMEcoj6DrC9l57BDPp/q1WCqL7G522DkXToUb3+E5WBwDzidzpdTYxAqMFNzM5znh4xs8PKVAdsPrWl+v1c6sJuLH0FGcrcUO2D+dkSrIurv/zcZHjHE5v+pncXyOuNsa5ihtyufRj2ZFXlBj6x8VzdneohB8yKrBdzC9aOustc+UfPmJeNPzI6As56mEYiRq0Gd2pYb/HqDiARzB7dNvu+AzWtI8Z8vlusPoBf7ymmgCIa4/BGZ/G+JkJK+1U1ElQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: andrew.cooper3@xxxxxxxxxx, anthony.perard@xxxxxxxxxx, jbeulich@xxxxxxxx, julien@xxxxxxx, oleksii.kurochko@xxxxxxxxx, roger.pau@xxxxxxxxxx, sstabellini@xxxxxxxxxx, dmukhin@xxxxxxxx
- Delivery-date: Tue, 24 Jun 2025 06:37:33 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/06/2025 05:55, dmkhn@xxxxxxxxx wrote:
> From: Denis Mukhin <dmukhin@xxxxxxxx>
>
> Rename HWDOM_VUART to HAS_VUART_MMIO.
>
> This emulator emulates only one register and the use of the emulator is
> limited to early boot console in the guest OS.
>
> No functional change.
>
> Signed-off-by: Denis Mukhin <dmukhin@xxxxxxxx>
> ---
> xen/arch/arm/Kconfig | 2 +-
> xen/arch/arm/Makefile | 2 +-
> xen/arch/arm/include/asm/domain.h | 2 +-
> xen/arch/arm/vuart.h | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index 03888569f38c..b11cb583a763 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -177,7 +177,7 @@ config HAS_VUART_PL011
> Allows a guest to use SBSA Generic UART as a console. The
> SBSA Generic UART implements a subset of ARM PL011 UART.
>
> -config HWDOM_VUART
> +config HAS_VUART_MMIO
I personally don't like this change. The current config option name reads much
better and clearly denotes the purpose.
~Michal
|
