Re: [PATCH v4] automation/eclair: update configuration of D4.10

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 10 Jun 2025, Jan Beulich wrote:
> On 06.06.2025 23:04, Stefano Stabellini wrote:
> > --- a/xen/arch/x86/include/asm/cpufeatures.h
> > +++ b/xen/arch/x86/include/asm/cpufeatures.h
> > @@ -1,6 +1,6 @@
> > -/*
> > - * Explicitly intended for multiple inclusion.
> > - */
> > +/* This file is intended to be included multiple times. */
> 
> While I can see that this may indeed be needed, ...
> 
> > +/*#ifndef X86_CPUFEATURES_H */
> > +/*#define X86_CPUFEATURES_H */
> 
> ... I wonder what this is about. Sorry, I didn't spot this as a change
> in v3. If it's needed, these comments want to be well formed (have a
> space between * and #).

Without it, ECLAIR throws other violations. But I can fix the lack of a
space.


> Beyond this - why is this header ending up different from e.g.
> public/errno.h, where a SAF-8 comment is used?

Because SAF-8 is meant to be used on top of an #ifndef and there is no
#ifndef here