[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MINI-OS PATCH 2/6] setup: drop parameter from map_shared_info()


  • To: Juergen Gross <jgross@xxxxxxxx>, <minios-devel@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 20 Jun 2025 17:38:36 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HmXWvIjVpphAD0tyUXrdGPKbfnf9wBxPfP67f4xpYTE=; b=xC+mErukiBtX+EcFzr9PsJtCaEuK8lR2KUl+Gsp6TWxLLEPOmZMpmA59Q71S5qtrRCqGF8G994c+HhVhxmSibON9YaMTJm0bgC1W38tGBhDD8MtK73fPd29kTicx3JpTDHLuYzsZigksUd/KBhDuik3mUaLdWRuhLgTftx4kFjZG3Msc3dWmgZWK2N2GAYcf3xqeVB8NrK1kFR2Mf1ZQuIHbBhPNRVgMT+NOwQtQSYjgez5Jdzx3hOftHOh1jlIHMDdcGGyftAcwT+wGo0GCyy6l7YqX1YWI7bWcrK39xP8ydh681Negk5FbT9m/I1Q/XRlrFSomZTSwlG+XX+uHkQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E2LeMd2MotBGCqgjddSFOrKtAPggS3uhr0Bn2+J+skfyxIBWQoH3FOddAkne3eGuW+w5b6RWiYpQ2AJ0i6NqLCHkOgBVRJJvrP+kp4QgNs4bWt7hxMS5iwJ/7t7pmPsCl+QknQ+louK31CXufWnRjLmnrSH3n7yzXOy434PqVpjRjkF/ObXuYIHmgpALK7amAyDTOVB2LTXQA2u2BBXGzN3sE23ENITCYBDnDYNnNxsQ4Y4mMPPK2Ja1TpggS8jvcboaN1Rjwp7eEfTyPa/nsnjN1FXhYkbm0TDXuU0gt2WhrSC698N8RKyAIjPD+PqXFCKgn9mYRH2tWm2phkMUOA==
  • Cc: <samuel.thibault@xxxxxxxxxxxx>
  • Delivery-date: Fri, 20 Jun 2025 21:38:41 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-06-19 07:38, Juergen Gross wrote:
The parameter of map_shared_info() is evaluated in PV mode only, and it
is always the pointer to the initial struct start_info from boot time.

By setting start_info_ptr a little bit earlier the PV variant of
map_shared_info() can just use start_info_ptr instead of a parameter.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---

diff --git a/arch/x86/setup.c b/arch/x86/setup.c
index e30eb065..1bdf9509 100644
--- a/arch/x86/setup.c
+++ b/arch/x86/setup.c

@@ -185,6 +184,8 @@ arch_init(void *par)
  {
        static char hello[] = "Bootstrapping...\n";
+ start_info_ptr = par;

Should start_info_ptr only be set for CONFIG_PARAVIRT?

Oh, patch 6 does that.  Strangely, patch 3 and 6 are not in my inbox.

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Regards,
Jason

+
        hpc_init();
        (void)HYPERVISOR_console_io(CONSOLEIO_write, strlen(hello), hello);



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.