[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5 04/18] xen/cpufreq: introduce new sub-hypercall to propagate CPPC data
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Thu, 19 Jun 2025 06:43:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9cQfdXGWrWvKYP7dnRjl1AHQe9WtEoBo755K0lNV97w=; b=szV/IZParAXvuYfL45XJ+tv+0ZkZ/6r9VZl/yP1ObJcPsJf1MjtduQaafa1+vaFJ9ChZScWuaVC4E+sNCzn2wCJIzvpP0hFia+ETXtsJdmeEliu3MrfSsgij6EV05j4nEXt3iSRsK+ODYvOElsrLGIXqEUktcsMQ8mo6KgBXIVUrOneQnGj1aMLMSDuVn7sUM6mwNfiqfuNPWKD9JznqDuudpEujg8Dz061dDK07MtQXLdW3po9Ur+PKte2AmMdzBUN4g+NP2GAExcT6DFxD2XEbtAMg6fcihBrXlcOj7ALjvENN52pcleILHlHh8VATaj7jmI4ioSF3mtD9QsDvBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KGw70z7erNUIoe3mKVpqMseyCC5Nk4+r+nK0B4Hk+qxbFyOwOBQn2s5leQSRi7FU2BIdCaiQqhC/HvOabOoOCOZhUIe0xcQzQFK4aTMkf4O7FU+5uR6cbjHgwl9xHZh/L549Iilcc6qnZUDZHZEYr4HWcvYFYSNDw6phjnPS8TZmYES/Tl+c9BvQNLXRnT4YW9Lra6hG5wIll/1+OHMlwdKp4hMY66daV9uLY0q/8+9CmoxwPLCYK2gjGBmObUE8GpAwnIWWPUfQut331kQ+vtUr0DDveIRsOMjX8ZfB2G20UFVIlo0EIEgCEG194H+Kaxl2Ag8wVPxhjuq+xoDlvw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 19 Jun 2025 06:43:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-06-19T06:43:16.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHbzuQ+jriHLS/NnEiww9yxRz3NOrP+OOqAgAvzMpA=
- Thread-topic: [PATCH v5 04/18] xen/cpufreq: introduce new sub-hypercall to propagate CPPC data
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, June 12, 2025 12:10 AM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 04/18] xen/cpufreq: introduce new sub-hypercall to
> propagate CPPC data
>
> On 27.05.2025 10:48, Penny Zheng wrote:
> > @@ -635,6 +641,124 @@ out:
> > --- a/xen/include/public/platform.h
> > +++ b/xen/include/public/platform.h
> > @@ -363,6 +363,7 @@ DEFINE_XEN_GUEST_HANDLE(xenpf_getidletime_t);
> > +struct xen_processor_cppc {
> > + uint8_t flags; /* flag for CPPC sub info type */
>
> A common way of commenting on such would be /* XEN_CPPC_... */.
>
> In any event, here and ...
>
> > + uint8_t pad[3]; /* padding and must be zero */
>
> ... here (and of course anywhere else) - please adhere to designated comment
> style.
>
Apart from Capital for the first letter, do designated comment style include
format like: IN/OUT: xxx?
>
> Jan
|
