[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 05/14] x86: Replace arch-specific boot_module with common one


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Alejandro Vallejo <agarciav@xxxxxxx>
  • Date: Tue, 17 Jun 2025 13:36:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q+hLMQohkGA0mRWXwRR+PeBKyEaJsyg0lqF1Eox3Abw=; b=Ki5RS7ASAWrg0c6AZjNhaoIr6cFB/7k4Aj0aOFOA4PuBUiapYfRQy1HIfHY/CguSCtWC5wWua32EWuwS5O2v8jauL3+aw7Bu/HlyyCA/HgYcNM+tADIQ6QYdWnuuaSrLWufqt4SeOCoBGWKc1W5ihgHCeeF5VwvkkxHCemm6FqOnlWRRc2Jcvc12caTLAVJpiKOlpQ0h2JmdxS4WYP05ttTuDK+YISEwYOnQ2a3+W5kowJovmYVI6Andn4d5cOUL1hMIij554ERvbcBXDF+PU+makNk6nHzJov1tnrUvyERL+46Hm/z1n0v61TckEiRuX+V0hq5acMtftBSDkctHrQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lOCG0I4flZ9h8dEWxSBJL8Bjju1Ix8G3YoxG9H47BLidE9NbPTo9S4Jjd/YTKT62LdtWsgtB+Qy6LidWWKMl2Uuk7riMBhnlqoonLd37JTOKemz8/b0jGjmLBxK1BAaGDhSSoqP9IWMqd0NMh+VrScIvouvA/Z+3QTWCUCSESuEcSuaNaqPHWqPPrmaTfrXozdC+GtPe6v7/JcLjXjqrnyL879d0uQbI1Y+uMCJTT5ZlTixz0VOL+as0Lpjd1KQbQWEZyIsBUy+CJLJ1/u+Xcpsen1sbbCXCBlep4wo5pcYMudj5Hj1n05Ae+9f0GPAoqh4cddwblwmvaifInbslRw==
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 17 Jun 2025 11:36:45 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Sat Jun 14, 2025 at 2:54 AM CEST, Stefano Stabellini wrote:
> On Fri, 13 Jun 2025, Alejandro Vallejo wrote:
>> diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c
>> index a038e58c11..8d2734f2b5 100644
>> --- a/xen/arch/x86/hvm/dom0_build.c
>> +++ b/xen/arch/x86/hvm/dom0_build.c
>> @@ -648,9 +648,9 @@ static int __init pvh_load_kernel(
>>  {
>>      struct domain *d = bd->d;
>>      struct boot_module *image = bd->kernel;
>> -    struct boot_module *initrd = bd->module;
>> +    struct boot_module *initrd = bd->initrd;
>
> It looks like struct boot_domain is still calling its member "module" at
> this point

Bah, yes. Way too many lines in the diff.

What's _really_ fun is that the pipeline passed. Including the job to build
each commit.

  https://gitlab.com/xen-project/people/agvallejo/xen/-/pipelines/1868636712

I'll have to look into what the hell happened.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.