[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5 03/18] xen/cpufreq: extract _PSD info from "struct xen_processor_performance"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Mon, 16 Jun 2025 09:43:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RVulP7Vi6An5GEs0rQDPdXKTKguq/7pkarZCmsj5ctM=; b=cO2dula6MuL3pjVkVoA2DEu7X2F8Tr7pKbXcgcvWb+QFT5F+W+UFqrxKL+9kqiJq5o95KRxaVGXhL7paTZkZathlLILaHEgtSbGjkEtGO9JjsIdlr5+FPHGsA7TxJxpWxBesQMQZbYLpeqHzUl1oo9nDHyg/KRBsHmihOZVk9yrRlOw6M+Ekc/K//byuMgjXDWBh7j5Fky63rHkBxYRh/rHW3sWOkqHkHpEEqYBTwckmUjObZELMbAH976IFmEzZzkB1HgLQR3sk1mU+glqcunwaW2EnvdFj0IamFNd05oflQhONAG1OOSYd0NTcgA1pgn4QILr5E9xeCAkyxhDVBQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v8OEzSzKKTnQSWAfa7OLiFThhmWs8ioHVAQJi1vA0bjbWCxPHJpL7VZMi1+jBqFoyE2SueEl5/BZkFUHF1mNMSCjvSJc61ZJyiepwhiofZW7tIiN/YLtitExyGs1me6FmgiCAoS4k9g0KkxjMcTGcjhpgmxd2VZIqhFwABhB+S7hkIGxMp+hUYDfri38ylNQUnqw3dcKX5rkJmb0OxmkVMPqPfqsmpMDP8iEDmPBxUxvqD6+mkI/OG68wa0jKa3ZqhrmpNdgBDRLztoDsVEH/gKNdcCEjyrfty1g3Fu0RqNWsvNCHgjKey9+rcDj3mM6mcbImYozJE8hCclMMvpchg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 09:43:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-06-16T09:43:06.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHbzuQ7tkLRAfE4aEeQu239amEhMrP+LqUAgAdzEsA=
- Thread-topic: [PATCH v5 03/18] xen/cpufreq: extract _PSD info from "struct xen_processor_performance"
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, June 11, 2025 11:34 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 03/18] xen/cpufreq: extract _PSD info from "struct
> xen_processor_performance"
>
> On 27.05.2025 10:48, Penny Zheng wrote:
> > @@ -545,14 +597,9 @@ int set_px_pminfo(uint32_t acpi_id, struct
> > xen_processor_performance *perf)
> >
> > if ( perf->flags & XEN_PX_PSD )
> > {
> > - /* check domain coordination */
> > - if ( perf->shared_type != CPUFREQ_SHARED_TYPE_ALL &&
> > - perf->shared_type != CPUFREQ_SHARED_TYPE_ANY &&
> > - perf->shared_type != CPUFREQ_SHARED_TYPE_HW )
> > - {
> > - ret = -EINVAL;
> > + ret = check_psd_pminfo(perf->shared_type);
> > + if ( ret )
> > goto out;
> > - }
> >
> > pxpt->shared_type = perf->shared_type;
> > memcpy(&pxpt->domain_info, &perf->domain_info,
>
> ... the need for this change. And even if there is a need, a follow-on
> question would
> be how this relates to the subject of this patch.
>
I extracted this snippet out for sharing the same checking logic both in Px and
later CPPC. They both need _PSD info
I could change title to "xen/cpufreq: make _PSD info common" and also add
description in commit message for
introducing check_psd_pminfo()
> Jan
|
