[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] arm/mpu: Enable read/write to protection regions for arm32
- To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Mon, 16 Jun 2025 05:57:06 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sztFwjggV4UNJ2Hc1FrZKNJw+nI5bTE2MBT88wTcXgY=; b=BeLJ9Ea9XgktpUR0Ji902fN/CZgLXTPrn5Qw57f+frr1mYJZfjxcA4b9pvHCu1/EfGVbQyXEjfkRL04Wp72ou7HWyap2yDFgEO7KOH8KcDek420VUTpHCeVISPcMaVsLe1ADkvzjFvtdTsE1CFDukz2UwUtoSlVQhLiaZI+oraK17E6ggfQX7gGsEJrDYLaQPtAvuEZJ0PP87JrD8dPAwwJOj35/TMoL4oWB8d7I/G3wv3T+zxYAT/1FzVBrdVrnVK6AMG/BBDStaeTzqSfC1mtTVbFaV7UB2P7gHypzqIEEgZR2toOcixPa8lqZ0Gnj6H8xYPLnvUfhp7gwmk/fQg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sztFwjggV4UNJ2Hc1FrZKNJw+nI5bTE2MBT88wTcXgY=; b=npVCA3vhGm86pV1VvS6UABnIhbDgUm9Xtoc6qhoSs5NCoh3ZwtLT2P3jABhTnxXLE7RUrZqypzsQThKnuGEKSAlv9YwqrmbBucEBR4MN8juA+5EBA4jS2wRBK4hOHGVc8hT7v2sYnXBOXxa88HGuuC1Lx4WEaYRpWRzrDR/q9JO++4P1FlzgIWJrpvCMYfC6KBKv+5Nski1NdFqsEHowE1aQLMGNumJedh7k0b+v22Of29ynJ0iidxcj7+DpI/zvIzGlPWsCEf0rZ8qHx450usaA5XHsfda1a2aU1wy5ok+bYOHIJXwiRcDcE/XxrmfBP5OWEbIPZrgmy0l1HZlnCg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=LEvYiqUdG0F2w8d502SAeear/fjjAfW/cVDewwVhp53Ym0HPkeeBqfjzyoM/GWjJxtX0yDYYXtYisZAnKMQgMCc2UhAA/+h8JWLxUPOrlMXHjscvEYujhQ0/T6I+IkRkjWSA0GDlEEhvyp0BtH+Sjz5/FP6bxN4QhdD+G+WnD2pZEDm+VrtW08ghrTY4s9mR4EkfcSupPWFbLwroHMCZlRSZPFa0BfaTnZqqMEkeqmjTbPOygbaL9HIQyZMiaSIOA5MEdGXbOOiWvHe27xgounbCHLZmpnaqbaQ+C9NyZ4h9ufuu+dRX4rPDvvIgQFnOz9/oxBVUNDpBEeCj0YQOhQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jTopw+b+IYE7d+9SU/2Lilfg5LGrMBtYx4VEHnkchMqZJ77BFzMVBN5dhXIcNnko9uwfTeBwgVjNc/NDLX+DGsKXCi7S7lTSaJgt/sDJfss7khdPMmjiStCesX9qhuaj88zeR8/Nc+DORfT4mZZLjZA+K4BN5AOdvz/HTJTkvmW2eHPCU5bsIfOnb6deOWXgOrPuzeoPyGQyk/xrUsRhZZ/pm3UyQfvqvibNyPIyn9Kkt8lJJyiiU/hCoJliOu0yFS2jHrbRT+/KhvDZk4C/UjuG9lXEUMS08MzrkAIHNW2PZV/r1nJHkt75a/coUWtxH5UGUjlQ2CdNmBJ5265iYQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 16 Jun 2025 05:57:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb2t7jddptbtJu60em4gEBgB1jlLQFURgA
- Thread-topic: [PATCH v3 6/6] arm/mpu: Enable read/write to protection regions for arm32
Hi Ayan,
> On 11 Jun 2025, at 15:35, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
>
> Define prepare_selector(), read_protection_region() and
> write_protection_region() for arm32. Also, define
> GENERATE_{READ/WRITE}_PR_REG_OTHERS to access MPU regions from 32 to 255.
>
> Enable pr_{get/set}_{base/limit}(), region_is_valid() for arm32.
> Enable pr_of_addr() for arm32.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> ---
> Changes from :-
>
> v1 - 1. Enable write_protection_region() for aarch32.
>
> v2 - 1. Enable access to protection regions from 0 - 255.
>
> xen/arch/arm/include/asm/mpu.h | 2 -
> xen/arch/arm/mpu/arm32/Makefile | 1 +
> xen/arch/arm/mpu/arm32/mm.c | 165 ++++++++++++++++++++++++++++++++
> xen/arch/arm/mpu/mm.c | 2 -
> 4 files changed, 166 insertions(+), 4 deletions(-)
> create mode 100644 xen/arch/arm/mpu/arm32/mm.c
>
> diff --git a/xen/arch/arm/include/asm/mpu.h b/xen/arch/arm/include/asm/mpu.h
> index 8f06ddac0f..63560c613b 100644
> --- a/xen/arch/arm/include/asm/mpu.h
> +++ b/xen/arch/arm/include/asm/mpu.h
> @@ -25,7 +25,6 @@
>
> #ifndef __ASSEMBLY__
>
> -#ifdef CONFIG_ARM_64
> /*
> * Set base address of MPU protection region.
> *
> @@ -85,7 +84,6 @@ static inline bool region_is_valid(const pr_t *pr)
> {
> return pr->prlar.reg.en;
> }
> -#endif /* CONFIG_ARM_64 */
>
> #endif /* __ASSEMBLY__ */
>
> diff --git a/xen/arch/arm/mpu/arm32/Makefile b/xen/arch/arm/mpu/arm32/Makefile
> index e15ce2f7be..3da872322e 100644
> --- a/xen/arch/arm/mpu/arm32/Makefile
> +++ b/xen/arch/arm/mpu/arm32/Makefile
> @@ -1 +1,2 @@
> obj-y += domain-page.o
> +obj-y += mm.o
> diff --git a/xen/arch/arm/mpu/arm32/mm.c b/xen/arch/arm/mpu/arm32/mm.c
> new file mode 100644
> index 0000000000..5d3cb6dff7
> --- /dev/null
> +++ b/xen/arch/arm/mpu/arm32/mm.c
> @@ -0,0 +1,165 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#include <xen/bug.h>
> +#include <xen/types.h>
> +#include <asm/mpu.h>
> +#include <asm/sysregs.h>
> +#include <asm/system.h>
> +
> +#define PRBAR_EL2_(n) HPRBAR##n
> +#define PRLAR_EL2_(n) HPRLAR##n
> +
> +#define GENERATE_WRITE_PR_REG_CASE(num, pr) \
> + case num: \
> + { \
> + WRITE_SYSREG(pr->prbar.bits & ~MPU_REGION_RES0, PRBAR_EL2_(num)); \
> + WRITE_SYSREG(pr->prlar.bits & ~MPU_REGION_RES0, PRLAR_EL2_(num)); \
I was also thinking that in this file now you can use directly HPR{B,L}AR<N>
instead of PR{B,L}AR<N>_EL2
Cheers,
Luca
|
