[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/6] arm/mpu: Introduce MPU memory region map structure


  • To: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 13 Jun 2025 15:30:33 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMIu5wUeJjbk+Ms45dViBZFyg9ZqYhOnoqv70elwZC8=; b=Lj0syba3sKWESx+FhGlGI7OYAb8ZzPrSniBx0RSZIwhd8XrHAai7snAax9GrvrcFEmpzKbLqZTJ/AILhRsvMDk2Wcr/SIvOUnlW1VmMp8646fkWOTMRAJJ9Mpcv/2sz/lVc8mydd15lLufo0dh1tZPY597ayAxHbsremV+OXcqrS9IbqYA2nh13BIhuhxwhEYP1vTh5XKM3OW2VXo2MxLAsFVl5ljCJeXnvnkMrTznXm4A1Tt1I+ffC3dlXTqfz3lOhq0n6jmrwk1Up6gxdNPU4gSf2fwlTo8QwHCL3X1hPz2R3V6pJy7WIAzAQE0Toy/TiSs897/77J9M00i4ftYQ==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMIu5wUeJjbk+Ms45dViBZFyg9ZqYhOnoqv70elwZC8=; b=IsUQPOxN4OKj+w32NCSDCAERBIMnx2atZhPSkgy37/2Lu6iifzNVDn2iJH/nm8E14751jVMtQF2iZUHa7Al+jrXsMFn8ViyXBIUMaj7uceyv0lBhDDHYz8p3oGXYxoO0v4yrTUxcgGTObjtECX8oksPicoT3BUCtczHTnL+hS8psnZnZT2QqVgYaNYWhtoWRtSMnHZdGIO7zyV4sH0FwC3Q/qjxOWWI24h/31Fb4OA5eYeCs9aEa7oFfV7dZtSwT74hmY7hYoezYAuAcPvDfVUSIoP35qv6YKfCLq4iViXiEwgKBFK+wB3GdqZNCmZshU3yVbVe9vw9d/wlvZzHjLg==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=X5yrAOypvwstGXzTq4brH42yrX4NL+IRnPKaRuvLlV3SPCodjTQGFKweNHqEXDC9+tMGMN7JvBE5CmKnlvcHIxVjvKja4HFVckZsJlSbp6aFNF5blCRXrBKI28fhQPIpzkOTdXJJg0fzHXQWW056y4+9k+1askIgcKIEZePPiUEZF8xX9KTG+JEQWlOgEJDaaA+3SAPfWewkY49z1/JuIT2cOPkHdMgxixeC4gD4fvFr0B41PZbPQrejDbAJ0IEfvgy1qqNbw03JJ9evfopO4Ws3n/LnKU3XxItCQjZlz6tKXQTABO068CRxAsMY8qHZRBFitx10iT08U4tGCz+n7w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vHLFM7R1bC6KidbrhaRJsRU3Qlj6dlVP0LiG3ycp0s3c5TccdaHYsKPPaEBJD7rBs1q7gnMlzihxoPSphMKr+xBljfNzygvR3lpuvhGKUbzazpaCdkgq0/DkFti8sZmIvp2HCtFVBT6MINXzplFHIlSBBbCozI8s6yZq9gh/3/lUJD5ZL+9NpYxG2YA/jg8nPTyOplmsTZNUfwMuHiGMt9Bbuhd/2Zk3m6Cw6EKc1ET7vfIj8+tndDpt43YcV/MkU2gsTR+VT4h+318CFyCAqpTA492/Pw7qUuISqSiFzWkdPLMWd/GCUZvRl8vBgnoBczRZnqPsCkriXNdjczebog==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 13 Jun 2025 15:31:12 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Thread-index: AQHb2t5CMbXSS0y8Xk2wSj8YvRec8LQBOlIA
  • Thread-topic: [PATCH v3 1/6] arm/mpu: Introduce MPU memory region map structure

Hi Ayan,

> On 11 Jun 2025, at 15:35, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
> 
> Introduce pr_t typedef which is a structure having the prbar and prlar 
> members,
> each being structured as the registers of the AArch32 Armv8-R architecture.
> 
> Also, define MPU_REGION_RES0 to 0 as there are no reserved 0 bits beyond the
> BASE or LIMIT bitfields in prbar or prlar respectively.
> 
> In pr_of_addr(), enclose prbar and prlar arm64 specific bitfields with
> appropriate macros. So, that this function can be later reused for arm32 as
> well.
> 
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>

LGTM! I’ve also built for Arm32 and Arm64.

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.