[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 20/20] xen/sysctl: wrap around sysctl hypercall
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Fri, 13 Jun 2025 08:57:09 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nlSauoV2LjRS8KayhtQ7JOGxzqrkeuD5EDozn8s/AVw=; b=UGsJa62apOKQRkIMgih8jwl3BKhmSkjJteZ3DmP70LX24Y9Kg6okFXgYl3E0GcwkETjSDsrR7ih/m46YjKr6MEthDJ4v9gKuFBX2iOTNbcjuETzCmf44nETnPmLsOUvm8QycR/LHe/2AaU3PQIe04soyH47PvbmyVOfKZEnxKWM+qOCO8VYkCa3S5IeOoyWR2+uEb3mt6hqVYJjHkwo5ujiDMmTy2mB9PB+h/TMFpXBvE2ODNgu2WjrFaZZBM1oa2HMA1EF13Im+t0f1iWiMsyygVHNu8+FKsqW6k4rbmwArM9EhONmvDMhANgIi5WOWCHOEAo4dGONiRguwEnV+ow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rdHkdiM3JQvLiy4rEkUjrzQS/LtkuFyVApMcw1tvAZYuDzAIF5LLj11iVREPqxin0YNg31t9k6sn47O/anvUKLQGp03rLOq0YRzPRCFqp9qg6CGqt0x5RSxYuZ4EOn+SZNPorzkGm4awkLuzewr4ClXG3fjih2lEsK16JAi/FOOClvw8nAett+qkGWRiymWzNQ3QAXn9wfCiNreMd74cR505oeumpA5RWQzV8vX3JSUtIihwalnf+3VMakjraJBtgk/W71cjPCfGpP470AmYPdm0fgf+UD8JWfLE5+1hG5Wi9100se2XozKz5X+CMAp8hdtlnPav/DYqfhnSL6dalA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stabellini, Stefano" <stefano.stabellini@xxxxxxx>, Sergiy Kibrik <Sergiy_Kibrik@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 13 Jun 2025 08:57:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-06-13T08:57:02.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHbz7GB7JuzUuWzwkuFXAiKCBRn07P8fpKAgARiCjA=
- Thread-topic: [PATCH v4 20/20] xen/sysctl: wrap around sysctl hypercall
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, June 10, 2025 9:53 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger
> Pau Monné <roger.pau@xxxxxxxxxx>; Anthony PERARD
> <anthony.perard@xxxxxxxxxx>; Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Stabellini, Stefano <stefano.stabellini@xxxxxxx>;
> Sergiy
> Kibrik <Sergiy_Kibrik@xxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 20/20] xen/sysctl: wrap around sysctl hypercall
>
> On 28.05.2025 11:17, Penny Zheng wrote:
> > From: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >
> > Wrap sysctl hypercall def and sysctl.o with CONFIG_SYSCTL, and since
> > PV_SHIM_EXCLUSIVE needs sorting in the future, we move them out of
> > PV_SHIM_EXCLUSIVE condition at the same time.
> >
> > We need to make SYSCTL with prompt back and state unsetting SYSCTL in
> > pvshim_defconfig to explicitly make it unavailable for PV shim.
>
> I'm struggling with this sentence. but nevertheless it seems pretty clear
> that what
> the latter half of the sentence says is not the effect of ...
How about “
We shall add "#CONFIG_SYSCTL is not set" in pvshim_defconfig to at least provide
correct preset for PV shim
"
>
> > --- a/xen/arch/x86/configs/pvshim_defconfig
> > +++ b/xen/arch/x86/configs/pvshim_defconfig
> > @@ -31,3 +31,4 @@ CONFIG_EXPERT=y
> > # HYPERV_HYPERV_GUEST is not set
> > # CONFIG_HVM is not set
> > # CONFIG_VGA is not set
> > +# CONFIG_SYSCTL is not set
>
> ... this change. The option is still going to be available; it's just that
> the preset is "off"
> now.
>
> Jan
|
