[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 17/20] xen/sysctl: make CONFIG_COVERAGE depend on CONFIG_SYSCTL
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Fri, 13 Jun 2025 06:35:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=453UZOf8DqXnlgtoH0CxSf+qNMouKVvUB4Lpp6Kfhs8=; b=M3OqMLoYJRc/SY6VtEFAGr0Qei16+t70Keiv1toiYNSrtNlCQXxtIM4QMmTY22jH9AUdLKun6ZxcjJXFDRKA/iRE8qDUDllNJjMQhDO4pbM5D6Uen0mg80+sSUxgo6b4HMQH76detgY02mhEcC94QJfVBsIg1vE7O7eBKrRTyK3dkSjp38HWLx5RjRIu7dh4iOBTf8QEmSyGxIVB2GotfNxx+8b8vZH68X7nWp3YP/YGulSgSLs+Mx7I/7FzqimB4eWDHcymAH16Rv69wH2LkpL2OrBR0zO+k7dMYIFNkFGUn1TVfVaf7w8TH7caaBS2pLQIQxyiUqDbFw3s0IMkZw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WUGq2G/yCv0hTDgYdQrR7yABVxaIT9mBOa2/5RrfmGQ5zDf+fxR3ChfO3BxCJwW9MGIBew/VN7fJa4Xnf6Gn97b5HxaShaCxV2GLW0kkbAnBp4fB7pDN9WYWPzBPA1mD7ABR0Ao1TXug9f1dC5S5cEF/lx5ZiHImOMPMY88HtpNLNd20XMtsETiYbq2k9p14bNvF59sg3S9Rg9KYWSizndWbg6Kta0XEd0QSkt76brBYVCxOMfZa3qGVkKYwYZk8sXI09R5lc8V6TPCWBvYwjhCthakG1HBgb+mgTsVbm1JT4o/6F8j4BCxeTX7tj3pGj+VO752DcgDBu91zsX0uYw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 13 Jun 2025 06:35:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=True;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-06-13T06:35:32.0000000Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=3;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged
- Thread-index: AQHbz7F7SunEZNF6NkqENGvwpWoLO7P8fREAgAQ9xqA=
- Thread-topic: [PATCH v4 17/20] xen/sysctl: make CONFIG_COVERAGE depend on CONFIG_SYSCTL
[Public]
Hi
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, June 10, 2025 9:48 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Anthony PERARD <anthony.perard@xxxxxxxxxx>;
> Orzel, Michal <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>;
> xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 17/20] xen/sysctl: make CONFIG_COVERAGE depend
> on CONFIG_SYSCTL
>
> On 28.05.2025 11:17, Penny Zheng wrote:
> > All coverage-related op shall be wrapped around with CONFIG_SYSCTL, so
> > we shall make CONFIG_COVERAGE depend on CONFIG_SYSCTL.
> >
> > Signed-off-by: Penny Zheng <Penny.Zheng@xxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > ---
> > v1 -> v2:
> > - commit message refactor
> > ---
> > v3 -> v4:
> > - commit message refactor
>
> Despite these efforts the description still fails to say _why_ the supposed
> wrapping
> is needed. And "supposed" because I can't really see any wrapping. All you do
> is
> add a dependency.
>
Will change it to
"
Users rely on SYSCTL_coverage_op hypercall to interact with the coverage data,
that is, according operations shall be wrapped around with CONFIG_SYSCTL.
Right now, it is compiled under CONFIG_COVERAGE, so we shall make
CONFIG_COVERAGE depend on CONFIG_SYSCTL
"
> And btw ...
>
> > --- a/xen/Kconfig.debug
> > +++ b/xen/Kconfig.debug
> > @@ -37,7 +37,7 @@ config SELF_TESTS
> >
> > config COVERAGE
> > bool "Code coverage support"
> > - depends on !LIVEPATCH
> > + depends on !LIVEPATCH && SYSCTL
>
> ... "depends on SYSCTL && !LIVEPATCH" would feel more naturally to me.
Understood
>
> Jan
|
