[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] arm/mpu: Move domain-page.c to arm32 specific dir
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Thu, 12 Jun 2025 08:48:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xRAfrnQaH0ueHVkW+B+X1iPuzeIYFft5fE4xMcX0vzk=; b=GmKz5XUfXsl6gBH9Gz5SrfhhBWEZW3iQCaqKyZKo/RxAvXds3U1WayzD80pIIPNZ5XLCmCrGRsKHwGOy/+syoQa6rPotggVAZKoycO/Z7TBo+3POLVHatzsK5rUfim8wiW36Hcuf9boXpUPHCj9O65PivUZ+3KANYKXpPt4GRp4fK47/vCwBSjn9ZNA2XFixz+MGWx26+CHxVW1LaLyQRS7yfhzUHXvf39O6QjGRXFOSIyUmaJasPwE+z9FQVUXvYKl+QheAW+Awm5WngCtU9O73zsA9BjJ6HPrVlcqbdG5bF41osKmotI1gS5bkyYzxXi1t7YunVZxpd/iBOgT1TQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a/T9if9LoovEIZSpsXWuFHELM9Aoi+XzdcsLEb6brFmKyhIM6SvUk+HuQis1r2zyIa0Wp9MmvPM9GItj25gvHpxUTWimgatvEAMavjHhrzkRCStwFy270ZqDNKBrT+TpSyZmfRcOhhjKUzXJolBmcjmIXG0IWho1Q22y7Ae9WKkBYY1840Y+lorwNqTMSOQ4aj2J3OuPSBuxYw7+gd4laOTShvQOK5JiHK4tk3GjvJyWWN7j+tfCYi30DokvcC4QMyKjxQ4fEfPAImT86JHRTnpIK2RussN0J3rraZ3LDX1JqmfjE8Qy4+CyGVQWwJURRGpoazmb3SXBny6AEuft+g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 12 Jun 2025 07:48:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11/06/2025 20:46, Luca Fancellu wrote:
Hi Ayan,
Hi Luca,
On 11 Jun 2025, at 15:35, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx> wrote:
Create xen/arch/arm/mpu/arm32 to hold arm32 specific bits.
Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
---
Changes from :-
v1..v2 - New patch in v3.
xen/arch/arm/mpu/Makefile | 2 +-
xen/arch/arm/mpu/arm32/Makefile | 1 +
xen/arch/arm/mpu/{ => arm32}/domain-page.c | 0
3 files changed, 2 insertions(+), 1 deletion(-)
create mode 100644 xen/arch/arm/mpu/arm32/Makefile
rename xen/arch/arm/mpu/{ => arm32}/domain-page.c (100%)
Uhm, why?
Arm64 is using domain-page.c:
https://gitlab.com/xen-project/people/lucafancellu/xen/-/commit/b28198d00078991d4a6502e94c8779d84fec0120
Did I miss something?
Oh, I did not look at the future patches. I can drop this patch in my
next series once you and Michal/Julien reviews the other patches.
I feel it is cleaner to have separate implementations for
prepare_selector(), read_protection_region(), write_protection_region()
between arm32 and arm64. (Refer patch 4 and 6)
Let me know how it looks like.
- Ayan
Cheers,
Luca
|
