[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: fix build with HAS_PCI
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 10 Jun 2025 08:42:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RPC9iPavFIQNXws7Q9IwJCwqAm2J9I8pLaLCui7orW8=; b=k0JN+004X+VRDukyqAarJm/wfGIOGiyo/mYLQqh69BRVCc0Iu+DqdKZf1+TLsToNn2EDa1SDJZ5H+/4sJc9NtCJt1gLtWEhJYaf0IVwK/2n6WlJa5u1E1iDVtd9IB6aKJrW8OFPRXJW5i4fsk7QxXV2l9h9i5fZv2NQP5zdVWvAJlGKeVlkr9kr8ova6wVHGWcCWQ0qZRPT/aG2zejVRf3MXwZvyw3wVOXPmfFiyN4DbaeDVe6o1Kko2DnnVB6a3Nm68fdA//05nmANi1+SdVBpqLChjV1g+7Oi/6NusBjW4Gw7AuSKxaG7QlXF9n9+h8Iz+QvqEVJFxE1TFOfybHQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M1TnPe+ALRtBM2QHR8zilhmJ8VT946KywxDve9xcQmNN/IjYdnKNBbjTQMvBGR6Ah7mkRCQemXxI8MwBgX+qEFBEtMmCZv+Ux1DHibWzdQBtAt+y4ToT+QVgiw7qVunPxIKBn4ENK3quIuAjOoVlcgKV02PCt7wesZdwB+xp9T4HuPPtvcLLJLtv6aPTFSmvxkA2WOMPPvS2EWeZ9ArsWngoJG2un3t3rg4/23ZGmmQWBV55X0WnpoDwjM3GH6mQoMh7dsLYfZO98cXzePI9gwE6ySC9vZ4lk7FF2S7kB3z5aZrZ7sWUmDQBHVfjPK77mNwjG6gO6Aq/D4BHgG217w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 10 Jun 2025 06:42:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/06/2025 22:54, Stewart Hildebrand wrote:
> In file included from ./include/xen/pci.h:72,
> from drivers/pci/pci.c:8:
> ./arch/arm/include/asm/pci.h:131:50: error: ‘struct rangeset’ declared inside
> parameter list will not be visible outside of this definition or declaration
> [-Werror]
> 131 | static inline int pci_sanitize_bar_memory(struct rangeset *r)
> | ^~~~~~~~
> cc1: all warnings being treated as errors
>
> Fixes: 4acab25a9300 ("x86/vpci: fix handling of BAR overlaps with non-hole
> regions")
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
> ---
> xen/arch/arm/include/asm/pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/arch/arm/include/asm/pci.h b/xen/arch/arm/include/asm/pci.h
> index 1605ec660d0b..1bbb9d780193 100644
> --- a/xen/arch/arm/include/asm/pci.h
> +++ b/xen/arch/arm/include/asm/pci.h
> @@ -17,6 +17,8 @@
>
> #ifdef CONFIG_HAS_PCI
>
> +#include <xen/rangeset.h>
Just for the struct, I think it would be better to forward declare it (at least
this is what we recently started to prefer). Especially given that rangeset.h
also forward declares it.
That said, I don't find it mandatory, so with or without:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
