[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 1/3] xen/keyhandler: add missing noreturn attribute
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: <victorm.lira@xxxxxxx>
- Date: Fri, 6 Jun 2025 14:27:07 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5YW/b3b+f5TMgHQiFZZLzwDRl6w9W7KsuqV06/eSyM=; b=NdLzZ9+lP1mNSZjJ8+jcwEAWsKVQijgrbHhff9bhXfEmzx9dGtr/yqXzxd3DvcT/bp3Sup1j29Kos8oOlh+2ulmMnZK+rBjBapTxwqI9V+0LpBstM2RkV7l1PKUjUAtpACvHqOngAChB5m8HMtucf5yAbyXvsJ3Re+jVRDRT/zb2auVNi5qg0nH8CdmBfidBW862N+IbR0KFexJdPvPhN2kRajYgBxXT4VugscokgKj1aqoKbg5WIL4M2L8j1cy6+baX8Ct3BLx9t69Hbebme3BaIUPWTPHht/XJTc9vllXb6Rrk3k81F29JYok3UN8iFiBKW7aGGzoxEt/Ef1qUhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wBD30eMPy3TePdkw1d8L9N+fPYHq+lG9Uq4kPtKX7+Qf1xWKfzPPuaYsqQJAt1/KaVqHZZM33NE5M+0uEcIfBL3VQGnvlJ47cIFMNhUNzuNwiDWrcGiOvBbK4ABuOa0TeVyY2AUMK5J4Nxg3Ci5EQcLc9Q2jSw7ykf5z10mdPIOz6Q2e8evFB2RbWDPNpt+PIRTPAR6YpzHU88kJ/INmBiq92qmbAunNT1pSzMjJjunBvOVePoXzv3fVRaOm1KfCYBn+YNV8qTjQXX2lmMb3ZAmBqhajyKiI7r8M40ibovn6QUxJ1NCBsHdV4QPXC05WnxUkj8Dl9mBe43tgzqNa9w==
- Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Victor Lira <victorm.lira@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "Anthony PERARD" <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Federico Serafini <federico.serafini@xxxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Fri, 06 Jun 2025 21:27:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Function `reboot_machine' does not return, but lacks the `noreturn'
attribute.
Functions that never return should be declared with a `noreturn'
attribute.
The lack of `noreturn' causes a violation of MISRA C Rule 17.11 (not
currently accepted in Xen), and also Rule 2.1: "A project shall not
contain unreachable code". Depending on the compiler used and the
compiler optimization used, the lack of `noreturn' might lead to the
presence of unreachable code.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Signed-off-by: Victor Lira <victorm.lira@xxxxxxx>
---
Changes in v2:
- improved commit message
---
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Cc: Michal Orzel <michal.orzel@xxxxxxx>
Cc: Jan Beulich <jbeulich@xxxxxxxx>
Cc: Julien Grall <julien@xxxxxxx>
Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>
---
xen/common/keyhandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/keyhandler.c b/xen/common/keyhandler.c
index 0bb842ec00..b0a2051408 100644
--- a/xen/common/keyhandler.c
+++ b/xen/common/keyhandler.c
@@ -251,7 +251,7 @@ static void cf_check dump_hwdom_registers(unsigned char key)
}
}
-static void cf_check reboot_machine(unsigned char key, bool unused)
+static void noreturn cf_check reboot_machine(unsigned char key, bool unused)
{
printk("'%c' pressed -> rebooting machine\n", key);
machine_restart(0);
--
2.25.1
|