[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 02/15] arm/gnttab: Break links between asm/grant_table.h and xen/grant_table.h


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Alejandro Vallejo <agarciav@xxxxxxx>
  • Date: Fri, 6 Jun 2025 12:02:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xfChG2vv9hSuddW3XR6SAVF6w9YZVG42YBzF3FgoU2w=; b=PmMC1VYDz/RUo1zUmkN/p44IBFKyll8BTeSKjFmunxf4BKWZkMU2wyQ9GzOwNtufJx6UQt+QS+l6dHWtIpSQreH2IlADGcJyKcLdKG9WL5J2bBvXcnfKoYhljU+4MIGUSXtgTbLKfvdQKpI6966HIni7q9pwoZx8gmCeHBGOH7ORWT9Cr5SlO7BaXzE8E2KE6XDOduUJ/gR43MrgL5z6MWVN9tsc2g43Ufxdfe6FjVES8q7FBexpaaI22CvZzZaHJ8u/LFnvyRnWJrqI076/kL5CMHXxndXRguw4CYpC4HpoLHD7EQElBBDjkXYoOe0FBD6vB8w4ahOFRXPUiFMB3Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TyZnNCqeWhSFYgtKcPaffar21qUXvNsmh2Y3bgiA52cFj7HWP4MlidB+SPbZF463Ww8/HpJpLCUfWnkL+JQnzD+Cli7CbtGKiYJBy0R4M8HRmJKOgOl/SXaxlW6kQtR/oy+5JLJoc9luN6np1omNNjldpbg7Fw5E6RiC+Avrkrw0lj4nlh8HYByXa4SFY6ERiWKnwannuD3AKozjfTwpiUmFd0PGHP3nfzJcO3qdTrPMDtxGjl5xhNgJ+lBmE/wfE9NUC6Jb4fnhLv+eBR9QYZ1kpHeFYpS/0D0WPTm0IfBnQYffrRQ7L0Ry3sZr1DdRCXFmeEE+TDwKRyDdM6KZdQ==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 06 Jun 2025 10:02:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri Jun 6, 2025 at 8:52 AM CEST, Jan Beulich wrote:
> On 05.06.2025 21:47, Alejandro Vallejo wrote:
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -42,8 +42,10 @@
>>  #include <xen/xvmalloc.h>
>>  #include <xen/nospec.h>
>>  #include <xsm/xsm.h>
>> +
>>  #include <asm/flushtlb.h>
>>  #include <asm/guest_atomics.h>
>> +#include <asm/grant_table.h>
>>  
>>  #ifdef CONFIG_PV_SHIM
>>  #include <asm/guest.h>
>> --- a/xen/include/xen/grant_table.h
>> +++ b/xen/include/xen/grant_table.h
>> @@ -27,10 +27,6 @@
>>  #include <xen/rwlock.h>
>>  #include <public/grant_table.h>
>>  
>> -#ifdef CONFIG_GRANT_TABLE
>> -#include <asm/grant_table.h>
>> -#endif
>> -
>>  struct grant_table;
>>  
>>  /* Seed a gnttab entry for Hyperlaunch/dom0less. */
>
> The description doesn't make clear why these two files need changing.
>
> Jan

What sort of description? I removed a conditional include  and added it to one
of the few places it didn't include it already along with xen/grant_table.h.

The title does say the patch removes the crossed includes in asm/grant_table.h
and xen/grant_table.h.

It's, I hope, self-explanatory regular spring cleanup.

Cheers,
Alejandro



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.