[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 09/10] vpci/msi: Free MSI resources when init_msi() fails


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Date: Fri, 6 Jun 2025 08:38:49 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mt32hQ7p33+cAqjPXWJDotYMJWDtFrIXhzS9EoW4sB8=; b=mtWNr5dxenlcKfIl4EeL7RSOkgdyuJr3eIIKiz5VsyTxB8NXz+qmbHjbcxduCyPL0xYSIrtTsxJMxdAYZ/JKj5ZHgq6bFB+5kTR/4zOUFyQptmWif5y3KPa6EN5uCWMSdkkA/Rwa2xj/MJA1T1fnhPw/FvC77GloaTrcJwPjRt/Jh93zoN+ReWAk7lEYxnmLyoRnZ4dpsCu3oQLThiJh903K1fcQHWjvdoNnHG+HNZ8t436fQafqIoLshSNncEG6AtRds6ijblUBen+NqzyzRzWo1e8ILxOrf5AUGtX+LPqFR3ZibrR67saD1YPcXLWzaCKIR9AQsWycXDP7E54uzw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Oao2gTWIxev4eZwzhbnp8fKbDx/RVRHP0mpKgbiu4qHPt7WUMqnKXwh5+6107BTH2t1p9lvYdg1Yj8tnu3Zbu7cENaHifwyQjGnYfxIjJd3DsmE1A+05lPpbGXEHys/BlR/qw6nLV+iRBQuMqSVHHu5rNY/tlQN0d9zkxb3yG18DdxrZv+LlRp9DbIwwr6QdTSz9BaGdoO7OTPZCs4JDTmcYrUaFmsvvofsPfZq+LatIGapCdii01cxsTogVWlnnMD4/rhKBFbV/9jWO+7Duragf+QE5epPrrI38/Gwudegzzj3DgLs6WYKDJP9Bv/B19qU7FFCtrjhNI2Yy5IZXOQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Delivery-date: Fri, 06 Jun 2025 08:39:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbziMSzFnidHY0zEiSVFmg3K6sv7P0vj8AgAGoAoA=
  • Thread-topic: [PATCH v5 09/10] vpci/msi: Free MSI resources when init_msi() fails

On 2025/6/5 23:19, Roger Pau Monné wrote:
> On Mon, May 26, 2025 at 05:45:58PM +0800, Jiqian Chen wrote:
>> When init_msi() fails, current logic return fail and free MSI-related
>> resources in vpci_deassign_device(). But the previous new changes will
>> hide MSI capability and return success, it can't reach
>> vpci_deassign_device() to remove resources if hiding success, so those
>> resources must be removed in cleanup function of MSI.
>>
>> To do that, implement cleanup function for MSI.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> ---
>> cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
>> ---
>> v4->v5 changes:
>> * Change definition "static void cleanup_msi" to "static int cf_check 
>> cleanup_msi" since cleanup hook is changed to be int.
>> * Add a read-only register for MSI Control Register in the end of 
>> cleanup_msi.
>>
>> v3->v4 changes:
>> * Change function name from fini_msi() to cleanup_msi().
>> * Remove unnecessary comment.
>> * Change to use XFREE to free vpci->msi.
>>
>> v2->v3 changes:
>> * Remove all fail path, and use fini_msi() hook instead.
>> * Change the method to calculating the size of msi registers.
>>
>> v1->v2 changes:
>> * Added a new function fini_msi to free all MSI resources instead of using 
>> an array to record registered registers.
>>
>> Best regards,
>> Jiqian Chen.
>> ---
>>  xen/drivers/vpci/msi.c | 29 ++++++++++++++++++++++++++++-
>>  1 file changed, 28 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
>> index 2d45c7867de7..4e106c39efae 100644
>> --- a/xen/drivers/vpci/msi.c
>> +++ b/xen/drivers/vpci/msi.c
>> @@ -193,6 +193,33 @@ static void cf_check mask_write(
>>      msi->mask = val;
>>  }
>>  
>> +static int cf_check cleanup_msi(struct pci_dev *pdev)
>> +{
>> +    int rc;
>> +    unsigned int end, size;
>> +    struct vpci *vpci = pdev->vpci;
>> +    const unsigned int msi_pos = pdev->msi_pos;
>> +    const unsigned int ctrl = msi_control_reg(msi_pos);
>> +
>> +    if ( !msi_pos || !vpci->msi )
> 
> Possibly same request as the previous patch, msi_pos should be after
> the PCI standard header.
msi_pos <= PCI_CAPABILITY_LIST ?
Or msi_pos < 0x40 ?

> 
> Thanks, Roger.

-- 
Best regards,
Jiqian Chen.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.