[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH xen/arm 1/1] xen/arm: Standardize R-Car platform Kconfig descriptions


  • To: Jahan Murudi <jahan.murudi.zg@xxxxxxxxxxx>, sstabellini@xxxxxxxxxx, julien@xxxxxxx, bertrand.marquis@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Fri, 6 Jun 2025 10:08:09 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/H1oDzcywQO9/UntSnvfvZiyyNydwEGkaN2gA6gebSI=; b=xmMy7tw/AsEcJJWydkGLy8NXwjHhIue+MLCt5tDfKlke8ZPcIIKdPQf/PcIobD2qN96c+Bt/jLzWxkkGhQX1ikzv3uTS6BkSBMgmI+NmKFmEzsluIPevaxhIK5jh3Y42T2FbeFxyiIbUOaUNqAe189GQWGVQFQt0JTasPblon96nqXsJC9fuh6ITcqNdpiAcOQcC/nVmRPEe4xLRtMQQ2nk5dY9wC1cOiSLIRWAJsCGL3P0AzTCtoNCej42BhlgVWRkNpikX+MPP4icOTOsgVFXsUnuH5w/S7nRaOAWjL57LV43+QctbBGsyRJ34bQSeOE3gcdWmwcx3wDD1ckKOqw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e522IREaWf3rKqZaVtpAtW50X1pw2vukLGNwF5TOSUUdgih/B7tEpGTvv6MXKkzCOfV0xWXIXndIdVnESfVytH8toHZ8uE3A7aVn7YnjY0qAklsqaspjxLETpVeIRWqnle2fmVUC0UkPxVuazmbRj9zAehSwQF4kTmqoDiscKlca7x674pg0bCzZO9Mpzah4xw9l6K0i3c247NbO11jkoihlDnDTd5XV+/eLa4Th3APDXaoHH3Lrl/mlcN/8vVprLLP2bVyvSnMHzobUAHJgzl+BbyfX5LgiSrNGll1xIn9iqxY6g+o/An9eCaN+YJKGZQr6gcSAdpInuspxwnksSg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Fri, 06 Jun 2025 08:08:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 06/06/2025 09:05, Jahan Murudi wrote:
> Changed "RCar3/RCar4" to "R-Car Gen3/Gen4" to match official Renesas branding
I mentioned this in the previous review. Please use imperative mood:
s/Changed/Change. Also, you're missing a dot at the end of sentence.

> Aligns with documentation and industry-standard terminology
> 
> Signed-off-by: Jahan Murudi <jahan.murudi.zg@xxxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal

> ---
>  xen/arch/arm/platforms/Kconfig | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig
> index 87bf614788..c8bc0bfae3 100644
> --- a/xen/arch/arm/platforms/Kconfig
> +++ b/xen/arch/arm/platforms/Kconfig
> @@ -22,21 +22,23 @@ config QEMU
>         machine.
>  
>  config RCAR3
> -     bool "Renesas RCar3 support"
> +     bool "Renesas R-Car Gen3 support"
>       depends on ARM_64
>       select HAS_SCIF
>       select IPMMU_VMSA
>       help
> -       Enable all the required drivers for Renesas RCar3
> +       Enable support for Renesas R-Car Generation 3 SoCs (H3, M3, etc.).
> +       Includes all required drivers and platform-specific features.
>  
>  config RCAR4
> -     bool "Renesas RCar4 support"
> +     bool "Renesas R-Car Gen4 support"
>       depends on ARM_64
>       select HAS_SCIF
>       select HAS_ITS
>       select IPMMU_VMSA
>       help
> -     Enable all the required drivers for Renesas RCar4
> +       Enable support for Renesas R-Car Generation 4 SoCs (V4H, V4M, etc.).
> +       Includes all required drivers and platform-specific features.
>  
>  config MPSOC
>       bool "Xilinx Ultrascale+ MPSoC support"




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.