[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 03/10] vpci/header: Emulate extended capability list for dom0


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Date: Fri, 6 Jun 2025 04:05:21 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6v0J+gcqrgdV++gz0L83VAg7D22l/I30zVfFVEbKdwI=; b=gaUQdNjkNcLbsZe68RjW9iKua5/ET7RNpk6vX00aK9VmI6vNwtTlyP3MikJXzqbrN0qMT9d/z0ULsgdCsKpeeHN3/BlXAYrB7TGu+bZRzk1qQwajpR3EEshSrzKlb1RUfSlAnymGhej5OlfIWEPXl5v7t3AlDd0yfwldSa8rq+c3YpuwGopbdOYXKELxp1anRWnPc6yAkK6JIkJ8T93AvLcW7WIopK8wuWyGMtDBWOWwf3k4gtdq+mTfg6lMjMe+3UpiAviT6JUJL1hT/xXOMywW3wCg78xduEaiSS4MHjXhCZvm5nYIEcjTj4WM5S8J+yGfwmomlNzWAJNyDegDPA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XBvoD4d/a/s2ruYvHYkDTRN90zm6//mlRPZ2vH2Mq8nTTajiAT5A/wde7m+Pn9ziI9/FplzzcfqYUYUEx4d8dYY55UebNmYBJ6h7quwzj1GVoyHFjUbjfr+JH3OWzbCR3vv4SypU/srZUE3di6DMSjfpTs08aHwAHQp7Vd4q/rYA0w2/1XQekO0Mq2dB+qkPQSdDSi+U18mgXMJJLGs6xku3bUEdWMx/AV2tTbJbS3fFWZF/dpidLFftI5p/qLBCsrqnPhUo/N28sqghaz8c6lf9G8np+TY/4m5FU8UcVwho67RddV/aGBYbNBaYdb64z5s+Ml8zbkARCzYEXf5YKQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
  • Delivery-date: Fri, 06 Jun 2025 04:05:34 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHbziMKXidFnyDUhE6S9bEvnc+iZ7P0fIKAgAGdrYA=
  • Thread-topic: [PATCH v5 03/10] vpci/header: Emulate extended capability list for dom0

On 2025/6/5 19:24, Roger Pau Monné wrote:
> On Mon, May 26, 2025 at 05:45:52PM +0800, Jiqian Chen wrote:
>> Add a new function to emulate extended capability list for dom0,
>> and call it in init_header(). So that it will be easy to hide a
>> extended capability whose initialization fails.
>>
>> As for the extended capability list of domU, just move the logic
>> into above function and keep hiding it for domU.
>>
>> Signed-off-by: Jiqian Chen <Jiqian.Chen@xxxxxxx>
>> ---
>> cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
>> ---
>> v4->v5 changes:
>> * Add check: if capability list of hardware has a overlap, print warning and 
>> return 0.
>>
>> v3->v4 changes:
>> * Add check "if ( !header )   return 0;" to avoid adding handler for
>>   device that has no extended capabilities.
>>
>> v2->v3 changes:
>> * In vpci_init_ext_capability_list(), when domain is domU, directly return 
>> after adding a handler(hiding all extended capability for domU).
>> * In vpci_init_ext_capability_list(), change condition to be "while ( pos >= 
>> 0x100U && ttl-- )" instead of "while ( pos && ttl-- )".
>> * Add new function vpci_hw_write32, and pass it to extended capability 
>> handler for dom0.
>>
>> v1->v2 changes:
>> new patch
>>
>> Best regards,
>> Jiqian Chen.
>> ---
>>  xen/drivers/vpci/header.c | 47 ++++++++++++++++++++++++++++++++-------
>>  xen/drivers/vpci/vpci.c   |  6 +++++
>>  xen/include/xen/vpci.h    |  2 ++
>>  3 files changed, 47 insertions(+), 8 deletions(-)
>>
>> diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c
>> index d26cbba08ee1..4b2f761c9c24 100644
>> --- a/xen/drivers/vpci/header.c
>> +++ b/xen/drivers/vpci/header.c
>> @@ -836,6 +836,42 @@ static int vpci_init_capability_list(struct pci_dev 
>> *pdev)
>>                                    PCI_STATUS_RSVDZ_MASK);
>>  }
>>  
>> +static int vpci_init_ext_capability_list(struct pci_dev *pdev)
>> +{
>> +    unsigned int pos = PCI_CFG_SPACE_SIZE, ttl = 480;
> 
> I think you can drop the ttl variable, as said by Jan in a previous
> review, the purpose of that counter is to detect overlaps in the PCIe
> config space, but for the context here the call to vpci_add_register()
> already serves that purpose by returning -EEXIST.
Will do in next version.

> 
> Thanks, Roger.

-- 
Best regards,
Jiqian Chen.

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.