[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/19] x86: Replace boot_module with bootmodule
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Thu, 5 Jun 2025 19:28:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v45liQZ9u4g8rrXd0GBP0aliU2oTKBvp3+NCfl7FqCY=; b=YkZ0oGK+O30SSpwJsUtuVrYwQU2bf0dvkPtnDA8n6/e46oNASOF9MF9O5xTZI0VoOXDigoXHscuEz4Ch1xO8q3Zo3o0TqUmblR6qL/pi3YnnLDL2kBaAUddI5wVrWAjEYxJvNuSweHVGUjfmspy5R9icnQKY4AM1JHKwFKdv3Fc70gYtxVSZeeIVovnx2H5vGhYpyjPf8dwTv6eR6GDQPLl2A2PrgHaw0WzAMI2jnfG5FLgpVnSDxdahNnFSxp6N373hTQ26OJV4jDGZLKbPbuFpX/O5THw2I2qW6YTXcCQfhZVQZQG3hp48BsfzB+x960XUkVVs8WyZbkYOpGiB2g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=slhFKtAi/znIfiSNnQ8DPwEk5K6l8KF3+uiAWRoJ41/3LJF2pOSvi6JCQKXJciNv6PatGq0o150MkFEsMrMmKNwvdElaAVZLwFJM9pudFfsW8iL+8J26l6UB0FDl7iAB2Yjpz56OKcxcpf4oPe/SLUjS8KVHFX0E9wqEL7yqL+Mtve0Vgab3hNeVb9e6sLwgZCfIp5HrZnKo4rOVX+TUfNyOY5XCpzyYgfaoeOUcGgvypA8o0r6r4BPKA0Jy9Mw7ml+RiOKWcEDiJpdHpgeIL00MXJk0Z3HQ0baWGvgf8mr9XqFDLS8+o7B5Zo3dvFRvOVuwrEaE5GtKL/+70q+zKQ==
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Michal Orzel" <michal.orzel@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 05 Jun 2025 17:28:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon Jun 2, 2025 at 7:00 PM CEST, Andrew Cooper wrote:
> On 30/05/2025 1:02 pm, Alejandro Vallejo wrote:
>> These types resemble each other very closely in layout and intent, and
>> with "struct bootmodule" already in common code it makes perfect sense
>> to merge them. In order to do so, add an arch-specific area for
>> x86-specific tidbits.
>>
>> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx>
>
> Yet this is a distinct backwards step in terms of legibility.
>
> How about modifying the common code to be more legible, rather than
> regressing the x86 code.
>
> ~Andrew
I meant to ifdef out the fields unused on x86, but after some massaging I
think I got it lookin much nicer. It's essentially using the common parts of
kernel_info and boot_domain as a header to kernel_info.
That way, x86 keeps using a substantially smaller (yet common) data structure
while the rest of dom0less can keep using the original as-is.
Refactoring kernel_info to rationalise its contents is somewhere in my TODO
list, but I have much more urgent fish to fry first.
Cheers,
Alejandro
|
