[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH 2/3] xen/arm: add missing noreturn attributes
From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> The marked functions never return to their caller, but lack the `noreturn' attribute, therefore causing a violation of MISRA C Rule 2.1: "A project shall not contain unreachable code". No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> Signed-off-by: Victor Lira <victorm.lira@xxxxxxx> --- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx> Cc: Michal Orzel <michal.orzel@xxxxxxx> Cc: Jan Beulich <jbeulich@xxxxxxxx> Cc: Julien Grall <julien@xxxxxxx> Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx> Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> Cc: Federico Serafini <federico.serafini@xxxxxxxxxxx> Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx> --- xen/arch/arm/efi/efi-boot.h | 2 +- xen/arch/arm/include/asm/arm64/traps.h | 2 +- xen/arch/arm/include/asm/processor.h | 2 +- xen/arch/arm/setup.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h index d2a09ad3a1..ee80560e13 100644 --- a/xen/arch/arm/efi/efi-boot.h +++ b/xen/arch/arm/efi/efi-boot.h @@ -934,7 +934,7 @@ static void __init efi_arch_blexit(void) efi_bs->FreePool(memmap); } -static void __init efi_arch_halt(void) +static void noreturn __init efi_arch_halt(void) { stop_cpu(); } diff --git a/xen/arch/arm/include/asm/arm64/traps.h b/xen/arch/arm/include/asm/arm64/traps.h index 3be2fa69ee..b7435c6e73 100644 --- a/xen/arch/arm/include/asm/arm64/traps.h +++ b/xen/arch/arm/include/asm/arm64/traps.h @@ -6,7 +6,7 @@ void inject_undef64_exception(struct cpu_user_regs *regs); void do_sysreg(struct cpu_user_regs *regs, const union hsr hsr); -void do_bad_mode(struct cpu_user_regs *regs, int reason); +void noreturn do_bad_mode(struct cpu_user_regs *regs, int reason); #endif /* __ASM_ARM64_TRAPS__ */ /* diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 9cbc4f9110..92c8bc1a31 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -571,7 +571,7 @@ extern register_t __cpu_logical_map[]; #endif #ifndef __ASSEMBLY__ -void panic_PAR(uint64_t par); +void noreturn panic_PAR(uint64_t par); /* Debugging functions are declared with external linkage to aid development. */ void show_registers(const struct cpu_user_regs *regs); diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 734e23da44..ed72317af3 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -63,7 +63,7 @@ bool __read_mostly acpi_disabled; domid_t __read_mostly max_init_domid; -static __used void init_done(void) +static __used void noreturn init_done(void) { int rc; -- 2.25.1
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |