[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/PV: make mmio_ro_emulated_write() static
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 04 Jun 2025 11:58:20 +0200
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1749031100; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=vG5hMSRJvNT1puUMge3SKwnwpuribeb27xPAyDjR0Zk=; b=hMPOr+6lneJou6xhLDOD/9iBlBs2shFO6wUjSg9fB8v51VGb9TeP2YPsnFsxPagAP1xm wyI5efABjdLfORwrtNq3wRCya4wHa3FLYrA0RVqVai/5gN7BCs72iWLaRYWb8kBLApOrQ vX4K0wX8/5zmRuIXCwtdlSlVhz/HioKcW/wBXc2ai7LAMi7B5V+DpeE1EeKh9mzLdqQh1 5qkG2qj5jAEWNGfFLTfCIWFAIyuJm34CN0jXcmXVk5h3mbtGoM9HqcHxncsoH6gj+dJXX nglVG57asbZ3JcCO2Tgb5yjQNf6COmnYiQ3wK93JADAcdaCoPyNhWy2s1v1Jdb1Ie6bMR SBYdpecebIwjV5MIHsc9uFSmcokh8iXCwcoiGR0JUk9P+mtqsD6Eb4C0Vqnu9eE27Ag87 tKUmiXJLcHsTXTlQtih9U8NKBOc59ZawwAOJuO8kkgodjmZCM9/unJY18kRr13z3euXRl AMXZ4UtqkNEH6U1PjkDJuzYY4ocvOwghBt6SIV82dOZIiICMs4GwOjHpJAT3fFAbBDUGY wVCtDazFlyPzrHc0Mpqqnn72AkZl3DQZwiV6N4FEP4fluDTM+A3vjE2gu+FBjCAPmiws6 LCCbfcH2yB6rEwHaNrq8rKBiUg9WdGBV2UBWm91DFiNj4JrH2EgdV3nONzn/5kk=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1749031100; b=0h5m+whCgad6zUSdf+EGt3dF1C3l0YfGYLA2b2q6s9kAJtcPmp6Myfk56rHO3yeP4pVa n4XG+1hv5Uuk4cNCZJwocvplIARjZuQV8rR9zual4koYT1OkFRTYeAYpSIwXz34FThnel FBpKxf5qiZ23+t4a7Jy5bARKpRbLr+yXIzs9dYYdPzUMEJIYmq1FvkwosQUbJ/I1180ZT JensKnroUXmP3AW6Tp3FbD7vz6mYDgiPCQvcwK6Zrs/AA8mZ8oQCC2yUCU3h/YSfffw5+ PTEnFYRc640OwSjYTBCotv2KsGT8A33FMvayW9Pu+0NQDBuKY0WiomK5vpj9SXL8OXDLx 8vFLIe+hGUzRCKpxdkjlPauIJFgsfyyLCPYnPeGi8ZN8DaVHyROygduVAdmJn0Mt3kGFJ ebZPhEWBuJMCuQsO6VAMf16L1xjuyU0vm+Zcc+Z2Fs3ehQ3U10RjR039JJkvVUl/tYIn1 aKrSfCMBIGq1cABrN4ihiALgoxMgQ3NXPzBLe4vnKHGsx63eAUYh5P4yMhAXJKcnNAEfS YWVhc8Z0XWeHdphavFLoSfjwkmdEDyHwj8DCiGtekd5vCYbvp483paNUEqCe7cLrz7/66 MD2FpOn6qkyt8TgvoxMCuBudDzSFI8m3SHpCdpi0SmWSJPtRu+7nt5RvGNpgOSM=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Wed, 04 Jun 2025 09:58:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-06-04 11:27, Roger Pau Monné wrote:
On Wed, Jun 04, 2025 at 11:22:00AM +0200, Jan Beulich wrote:
It being non-static and it not having a declaration (anymore) violates
one or more Misra rules, iirc.
Fixes: ff3e5dfa7c2d ("x86/mm: move mmio_ro_emulated_write() to PV only
file")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
We are not checking for those rules in Eclair I think? Otherwise this
won't have passed the CI testing. Or maybe we are just checking
builds with !CONFIG_PV?
Thanks, Roger.
That seems to be the case on x86. On Arm64 there is no override for
CONFIG_PV [1], but perhaps that is unset by default? I'm not opposed to
having more variants under analysis, but that is not something I can
decide on individually.
Thanks,
Nicola
[1]
https://gitlab.com/xen-project/hardware/xen/-/blob/staging/automation/gitlab-ci/analyze.yaml?ref_type=heads
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
