[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/5] xen/arm: dom0less: Add trap-unmapped-accesses


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
  • Date: Tue, 3 Jun 2025 14:59:49 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDknBqx6r+bD0zEt/g92j+dwpHxuazo88oXLlU1/jfU=; b=inEI3BB7Z08HgHWnAeV3UsNZeSRvWfzY+JKlYPwU7pDsv07bxXgWojxNLsGui/FZ6RJZ1TI3/RITNx5FpMj8Xe3mG/4ykfD/RBuZN366IbtYaFWaOUqbaGcatPayQzLRj5dIOess3t/iwxmIwaZJAMSXhCUAXC3GSDP0SZ1cyg/bwLpiE4jwwPfmQxmlXWLxIDMcHsOreMOj+UOFcAUhfA1j3VCSZKdceDYFeN7CM/PqQMgeCDu11F0oBzZ18P9BKyWD5DnjMrefIAnoNW43nEnRANzTdIbPMN7uhsBFlWJ3aa5ueRyBkT8Iu1P8ytK5S0hH5WakCQYKxdUWmjhYDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YPZwajjFx39L0eaZ0CwdLZ02AV6SjOrarltq7bE7K7VP1dc/ORVPeaYT20ZbnpwFgUaj7agABOsZrJDyPduTLkOspE0Iv4L+/iqP6Vdsqu2X+R/zh2DTfUR6ncjJXJj0odRmJbVe831niInqTh16HgFP7Y+TkiY2y+rSHAW3vQIzJDYrxrueeIa2qcDhMpCb0AWthLAhUXV0Wdfb4yCXns2qjMDvqjLmfS6ZRsKwfTZdUYSjkWkkAJdhbT3LAaGiHaapJ1B+PZehhPYxc4hpKuzOLgsK9GeTU4hZPxyJB6GLNsZhmcMk98D+e8N+QvR4iyrRElayKq1jiOJTdtgW2Q==
  • Cc: Julien Grall <julien@xxxxxxx>, "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <michal.orzel@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 03 Jun 2025 13:00:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Jun 02, 2025 at 03:57:28PM -0700, Stefano Stabellini wrote:
> On Mon, 2 Jun 2025, Julien Grall wrote:
> > Hi,
> > 
> > On 02/06/2025 23:36, Stefano Stabellini wrote:
> > > On Fri, 30 May 2025, Edgar E. Iglesias wrote:
> > > > From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
> > > > 
> > > > Add the trap-unmapped-accesses per-domain fdt property.
> > > > 
> > > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
> > > > ---
> > > >   docs/misc/arm/device-tree/booting.txt | 10 ++++++++++
> > > >   xen/arch/arm/dom0less-build.c         |  9 ++++++++-
> > > >   2 files changed, 18 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/docs/misc/arm/device-tree/booting.txt
> > > > b/docs/misc/arm/device-tree/booting.txt
> > > > index 59fa96a82e..9add6440de 100644
> > > > --- a/docs/misc/arm/device-tree/booting.txt
> > > > +++ b/docs/misc/arm/device-tree/booting.txt
> > > > @@ -225,6 +225,16 @@ with the following properties:
> > > >       option is provided with a non zero value, but the platform doesn't
> > > > support
> > > >       SVE.
> > > >   +- trap-unmapped-accesses
> > > > +
> > > > +    Optional. An integer that configures handling of accesses to 
> > > > unmapped
> > > > +    address ranges.
> > > > +    If set to 0, guest accesses will read all bits as ones, e.g
> > > > 0xFFFFFFFF
> > > > +    for a 32bit access and writes will be ignored.
> > > > +    If set to 1, guest accesses will trap.
> > > > +
> > > > +    This option is only implemented for ARM where the default is 1.
> > > 
> > > Please expand it to: "This option is only implemented for ARM where the
> > > default is 1 when trap-unmapped-accesses is absent."
> > 
> > I am confused. The document is part of "docs/misc/arm" and some options like
> > "sve" are Arm specific. We don't mention this is Arm only because the
> > documention is Arm specific.
> > 
> > I know that RISC-V is starting to share the bindings. So really (part of) 
> > the
> > documentation should be moved to common. Until then, I think it is 
> > misleading
> > to add "is only implemented for ARM".
> 
> Yes you are right. Maybe Oleksii or Alejandro can fix this, moving this
> file to common.
> 
> For this smaller patch series, I would remove the "is only implemented
> for ARM".

Thanks, I've changed that line to:
"The default is 1 when trap-unmapped-accesses is absent."

Cheers,
Edgar



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.