[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/5] tools/arm: Add the trap_unmapped_accesses xl config option


  • To: Julien Grall <julien@xxxxxxx>
  • From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
  • Date: Tue, 3 Jun 2025 14:49:45 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeH+6vE3mqu6gFB7KJtAW7zewFOjGEkZ3/AZ4fTWlOc=; b=VrwfpoSDzEX2Lq1YaqnCcpusOTEQ2VecO3KZD4ef/X/uff4t8SwNZ4E4FvXOk/OmQVjNlJ23pic6G/4vHA5saGimpN6KAujvZw8LQCBVzr89I1jXyvGoO6erlb8SaDmaA4gJrwtCzzT2eaieoByW2xDUDuUkb/STieNKwWMXWYwLc2JC8teSJkUEEBplyM0yDLBoDnqE9AKdsMuZShou8KI+i4L9uqLRiiVSdZHovttXiVqfDHXIiNUNqOrAqGSC8UgblktyWy/ZGfWicgGz498AKKdOQaxMH23es8P+X0x82FXIe8pb2Np+w9F884LG/zT0URXS5FHE9rJhssT5DQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I6vCE3WSXb4T4etHk1yCwA9Mp2Xyccyhg8mfFIE9qtDymJJmzSHHukfjr+Sl+hsMTVEis+KNyZ/KsYOlK8ACLIqUDWhdGU2m1fiykkf+ksMwE16NpXuQF/gNVCmP72FierHzHLUYFJt8q7IVycpcrMNKp4LQpiEOcJWeeNsF5NS+2eEEXJYLTzoGTo2lzppqsje91SK9qtK3TSaZFrurJe8WSvrwEIEFhWBJgI3x89Ja8ipNOXzwEUgahFibo3pvSfgsb7SaZxiKFdHyS/x/MYdpjJUsYp5NrWqNY4S9B8zrK4APkixeFP30I5LpSu5S4ZoYD2JcbY79jD+q41JqTg==
  • Cc: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <michal.orzel@xxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 03 Jun 2025 12:50:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jun 03, 2025 at 10:34:53AM +0100, Julien Grall wrote:
> Hi Edgar,
> 
> On 30/05/2025 14:45, Edgar E. Iglesias wrote:
> > @@ -1714,6 +1711,9 @@ int 
> > libxl__arch_domain_build_info_setdefault(libxl__gc *gc,
> >       /* ACPI is disabled by default */
> >       libxl_defbool_setdefault(&b_info->acpi, false);
> > +    /* Trapping of unmapped accesses enabled by default.  */
> > +    libxl_defbool_setdefault(&b_info->trap_unmapped_accesses, true);
> > +
> >       /* Sanitise SVE parameter */
> >       if (b_info->arch_arm.sve_vl) {
> >           unsigned int max_sve_vl =
> > diff --git a/tools/libs/light/libxl_create.c 
> > b/tools/libs/light/libxl_create.c
> > index e03599ea99..38770eea5b 100644
> > --- a/tools/libs/light/libxl_create.c
> > +++ b/tools/libs/light/libxl_create.c
> > @@ -667,6 +667,9 @@ int libxl__domain_make(libxl__gc *gc, 
> > libxl_domain_config *d_config,
> >           if (libxl_defbool_val(b_info->vpmu))
> >               create.flags |= XEN_DOMCTL_CDF_vpmu;
> > +        if (libxl_defbool_val(b_info->trap_unmapped_accesses))
> > +            create.flags |= XEN_DOMCTL_CDF_trap_unmapped_accesses;
> > +
> >           assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT);
> >           LOG(DETAIL, "passthrough: %s",
> >               libxl_passthrough_to_string(info->passthrough));
> > diff --git a/tools/libs/light/libxl_types.idl 
> > b/tools/libs/light/libxl_types.idl
> > index 9bb2969931..e33785c661 100644
> > --- a/tools/libs/light/libxl_types.idl
> > +++ b/tools/libs/light/libxl_types.idl
> > @@ -736,6 +736,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >       ("vmtrace_buf_kb", integer),
> >       ("vpmu", libxl_defbool),
> > +    ("trap_unmapped_accesses", libxl_defbool),
> 
> I think you want to add a LIBXL_HAVE in tools/include/libxl.h for this new
> field.

Thanks, adding it in v4.


> 
> Cheers,
> 
> -- 
> Julien Grall
> 



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.