[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 3/5] tools/arm: Add the trap_unmapped_accesses xl config option
On Tue, Jun 03, 2025 at 10:34:53AM +0100, Julien Grall wrote: > Hi Edgar, > > On 30/05/2025 14:45, Edgar E. Iglesias wrote: > > @@ -1714,6 +1711,9 @@ int > > libxl__arch_domain_build_info_setdefault(libxl__gc *gc, > > /* ACPI is disabled by default */ > > libxl_defbool_setdefault(&b_info->acpi, false); > > + /* Trapping of unmapped accesses enabled by default. */ > > + libxl_defbool_setdefault(&b_info->trap_unmapped_accesses, true); > > + > > /* Sanitise SVE parameter */ > > if (b_info->arch_arm.sve_vl) { > > unsigned int max_sve_vl = > > diff --git a/tools/libs/light/libxl_create.c > > b/tools/libs/light/libxl_create.c > > index e03599ea99..38770eea5b 100644 > > --- a/tools/libs/light/libxl_create.c > > +++ b/tools/libs/light/libxl_create.c > > @@ -667,6 +667,9 @@ int libxl__domain_make(libxl__gc *gc, > > libxl_domain_config *d_config, > > if (libxl_defbool_val(b_info->vpmu)) > > create.flags |= XEN_DOMCTL_CDF_vpmu; > > + if (libxl_defbool_val(b_info->trap_unmapped_accesses)) > > + create.flags |= XEN_DOMCTL_CDF_trap_unmapped_accesses; > > + > > assert(info->passthrough != LIBXL_PASSTHROUGH_DEFAULT); > > LOG(DETAIL, "passthrough: %s", > > libxl_passthrough_to_string(info->passthrough)); > > diff --git a/tools/libs/light/libxl_types.idl > > b/tools/libs/light/libxl_types.idl > > index 9bb2969931..e33785c661 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -736,6 +736,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > ("vmtrace_buf_kb", integer), > > ("vpmu", libxl_defbool), > > + ("trap_unmapped_accesses", libxl_defbool), > > I think you want to add a LIBXL_HAVE in tools/include/libxl.h for this new > field. Thanks, adding it in v4. > > Cheers, > > -- > Julien Grall >
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |