[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/vpci: Use $(CC) instead of $(HOSTCC)


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: "Orzel, Michal" <michal.orzel@xxxxxxx>
  • Date: Tue, 3 Jun 2025 08:41:22 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TOjuW9QwbIty0CAr6oR6MYezSB5oFWNTZo6fdq2u8t8=; b=aR04URdDH3aiyxo/azqeXE1c4vwbYTeZ6vfBtZ+ng6JvIOmP0TqvbRXtbR5dWuKmEjiRz3FnByC4koKR9CWY5+U5OpTVjk9TkyE2wU30QtbDcwPMu/TGT/o5Nq8U3tUK3//BxXIVj6C1L5YRoe+83kBQ+MNk3WgU6P+J3t49ENczIjV16KT7nWxiXP91CMeRBzRR8AjS/Ew048qAwfS2rhAbhXV0sXAM3cHALET7ZIvnODyEBz4hUmkGwzKoc46VgNfanSfGbNPNUDGxio2zUTxUeNGdxf4c1oEJ5eWqc/IxvcIhYwAcZclKc3Q5BAKyhhEYtYr3vQs9RDjUuRH+tQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ERWlHnt4ZDS74VEkHMLqWQSLYcmKAHbuOlGSjPgfr6xetKuvFbpOYTjWbWtD7kIeh7TXDPdBTyxZxGcvENaIzlBl7PhOeS3C2gcRuTTau/NMres71dif65CkzWYQIWWtU0mSpJ4lVdqzAY4hT2srm/2tyvcAyZ8NbuJW+pe50PgTn4aGkqm1YFgDDAi3KWuDAgwDt+DwYGZnhK0yesofYNePoF6DcA0e8tE7yCs9zRTktAbz2ox0el7rU6z/miiF83aBm0KeDYJrDUCs+NVyYSnzhVTb2XrdQ0g8dbot1XN5IeIghYCaPN6O6vWECHs34aoSoiKAKEbrrfJ+Jsbqaw==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 03 Jun 2025 06:41:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 02/06/2025 17:50, Jan Beulich wrote:
> On 02.06.2025 17:36, Andrew Cooper wrote:
>> On 02/06/2025 4:09 pm, Michal Orzel wrote:
>>> These tests are supposed to run on target. HOSTCC can be different than
>>> CC (when cross-compiling). At the moment, tests installation would put
>>> a binary of a wrong format in the destdir.
>>>
>>> Fixes: e90580f25bd7 ("vpci: introduce basic handlers to trap accesses to 
>>> the PCI config space")
>>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>>
>> Oh.  This didn't explode in GitlabCI because there's no ARM version of
>> *-tools-tests-*.
>>
>> Can we fix that too please, seeing as there is a real ARM board?
>>
>> Also, I guess we have to finally sort out the CC vs HOSTCC debate.
> 
> I think the situation here makes pretty clear that HOSTCC is almost always
> wrong to use for tests/. The emulator test harness is special in that it (in
> principle) needs a target compiler (CC) and additionally an x86 one (with no
> present representation). The present way of (partly) distinguishing the two
> by using CC and HOSTCC was assigning wrong meaning to one (perhaps both) of
> them. The (or maybe just my) problem is that in the toolchain world it is
> build, host, and target which are distinguished. As per Michal's description
> my understanding is that HOSTCC is matching "build" there, not "host".
Yes, I found this issue while building latest Xen with Yocto. Build is x86, host
is Arm. HOSTCC is x86 gcc, CC is Arm gcc.

I take as this patch is waiting for a maintainer tag? Not that it needs to wait
for some generic cleanup?

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.