[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 10/19] x86: Replace boot_module with bootmodule
On Sat May 31, 2025 at 3:15 AM CEST, Stefano Stabellini wrote: > On Fri, 30 May 2025, Alejandro Vallejo wrote: >> These types resemble each other very closely in layout and intent, and >> with "struct bootmodule" already in common code it makes perfect sense >> to merge them. In order to do so, add an arch-specific area for >> x86-specific tidbits. >> >> Signed-off-by: Alejandro Vallejo <agarciav@xxxxxxx> >> --- >> xen/arch/x86/cpu/microcode/core.c | 9 ++-- >> xen/arch/x86/hvm/dom0_build.c | 10 ++--- >> xen/arch/x86/include/asm/boot-domain.h | 4 +- >> xen/arch/x86/include/asm/bootfdt.h | 52 +++++++++++++++++++++++ >> xen/arch/x86/include/asm/bootinfo.h | 58 +++----------------------- >> xen/arch/x86/include/asm/setup.h | 6 +-- >> xen/arch/x86/pv/dom0_build.c | 8 ++-- >> xen/arch/x86/setup.c | 52 ++++++++++++----------- >> xen/include/xen/bootfdt.h | 9 ++++ >> xen/xsm/xsm_policy.c | 4 +- >> 10 files changed, 113 insertions(+), 99 deletions(-) >> create mode 100644 xen/arch/x86/include/asm/bootfdt.h >> >> diff --git a/xen/arch/x86/include/asm/bootfdt.h >> b/xen/arch/x86/include/asm/bootfdt.h >> new file mode 100644 >> index 0000000000..c00de8c09b >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/bootfdt.h >> @@ -0,0 +1,52 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +#ifndef __ARCH_X86_BOOTFDT_H__ >> +#define __ARCH_X86_BOOTFDT_H__ > > With the new convention this is just X86_BOOTFDT_H Ah, right. I forgot about that. Sure. >> +#include <xen/types.h> >> + >> +struct arch_bootmodule >> +{ >> + /* >> + * Module State Flags: >> + * relocated: indicates module has been relocated in memory. >> + * released: indicates module's pages have been freed. >> + * fdt_cmdline: indicates module's cmdline is in the FDT. >> + */ >> + bool relocated:1; >> + bool released:1; >> + bool fdt_cmdline:1; > > This is not actually used or needed in this patch? Bah. This is a later addition in the dom0 DTB series. I pulled it here too by mistake. Good catch. Cheers, Alejandro
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |