Re: [PATCH v4 2/2] xen/domain: rewrite emulation_flags_ok()

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Hello,

Le 31/05/2025 à 00:05, dmkhn@xxxxxxxxx a écrit :
> +        /* PVH dom0/domU or HVM domU */

This one is actually PVH dom0.

> +        {
> +            .caps   = CAP_HVM | CAP_HWDOM,
> +            .min    = X86_EMU_LAPIC | X86_EMU_IOAPIC | X86_EMU_VPCI,
> +            .opt    = 0,
> +        },
> +
> +        /* HVM domU */
> +        {
> +            .caps   = CAP_HVM | CAP_DOMU,
> +            .min    = X86_EMU_ALL & ~(X86_EMU_VPCI | X86_EMU_USE_PIRQ),
> +            /* HVM PIRQ feature is user-selectable. */
> +            .opt    = X86_EMU_USE_PIRQ,
> +        },
> +
> +        /* PVH */

And this one being PVH domU.

> +        {
> +            .caps   = CAP_HVM | CAP_DOMU,
> +            .min    = X86_EMU_LAPIC,
> +            .opt    = 0,
> +        },

With that

Reviewed-by: Teddy Astie <teddy.astie@xxxxxxxxxx>

Teddy


Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech