Re: [PATCH v2 1/3] xen/arm: Add way to disable traps on accesses to unmapped addresses

[Julien Grall <julien@xxxxxxx>]

On 29/05/2025 17:23, Edgar E. Iglesias wrote:
> On Thu, May 29, 2025 at 04:59:21PM +0100, Julien Grall wrote:
> > Hi Edgar,
> Hi Julien,
>
>
> > On 29/05/2025 16:50, Edgar E. Iglesias wrote:
> > > From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxx>
> > >
> > > Add a per-domain way to optionally disable traps for accesses
> > > to unmapped addresses.
> > >
> > > The domain flag is general but it's only implemented for ARM for now.
> > >
> > > Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxx>
> > > ---
> > >    tools/libs/light/libxl_arm.c  |  3 +++
> > >    xen/arch/arm/dom0less-build.c |  3 +++
> > >    xen/arch/arm/domain.c         |  3 ++-
> > >    xen/arch/arm/domain_build.c   |  3 ++-
> > >    xen/arch/arm/io.c             | 36 +++++++++++++++++++++++++++++++++--
> > >    xen/common/domain.c           |  3 ++-
> > >    xen/include/public/domctl.h   |  4 +++-
> > Looking at the changelog, I saw you removed the go bindings (although, they
> > were in patch 3). But I don't quite understand why.
> I got a little confused. The file tools/golang/xenlight/helpers.gen.go
> has the following at the top:
> // Code generated by gengotypes.py. DO NOT EDIT.
> // source: libxl_types.idl
>
>
> So I got the impression that we shouldn't be editing it.
> Should I edit it manually? Or should I try to rerun gengotypes.py
> to generate these bindings?
As the file is checked in, I think we expect the developper to rerun 
gengotypes.py. Anthony, can you confirm?
Cheers,

--
Julien Grall