Re: [PATCH v6 3/6] arm/mpu: Provide and populate MPU C data structures

[Julien Grall <julien@xxxxxxx>]

On 29/05/2025 10:52, Luca Fancellu wrote:
> > On 29 May 2025, at 10:45, Julien Grall <julien@xxxxxxx> wrote:
> > On 23/05/2025 07:54, Luca Fancellu wrote:
> > >   /*
> > >    * Macro to prepare and set a EL2 MPU memory region.
> > >    * We will also create an according MPU memory region entry, which
> > > @@ -59,6 +79,24 @@
> > >       dsb   sy
> > >       isb
> > >   +    /* Load pair into xen_mpumap and invalidate cache */
> > AFAICT, you don't invalidate the cache below. What did I miss?
> oh right I forgot to update this comment, Should I respin the serie or could it 
> be addressed
> on commit?
>
> I would amend the comment as:
> /* Load pair into xen_mpumap */
It can be done on commit.

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall