[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/6] arm/mpu: Introduce MPU memory region map structure
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Thu, 22 May 2025 10:12:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m5BnwMZWJ5rCtGRJQphXq/CaIfE5mry3HMFkIt1E0K0=; b=itnU7YYn2A2QiPTl17H01+0IBBVTkEkf9o3GQY9HNouVpCh6E6NtcKpafZ5jL/AH+DBavs07HpW8kiGfsD0xN4Z50jLoCCmWUaiOBILmIjPcNg/TcJbHHc6/chh5VAARHhi3J8bOGmtk2byZGAXFnVJiczWQpVUXKM1E+rG8tiECtjfmbtiD7SWlT8HGmUPg6o0/gU8/qGjiO02qoYEdvgbHX9OoB+9LF6kaUl5/sF0U+8wSf/oYBcYe4mkqvDzonYVgrX85rkMb9S3v5lt95jU5CVrrfU3kqVf7ZEwUzM/dpn5TEXtWJn4j1Cl70GYiVYImxrZzSeUoSDcBP+FZyA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=y7A2K7ssKzJvLe/tJfjs5qUvcb/FS3DfRJXPnNLbJyvuwqK3H4ahEo/yOJpx+y5oqw0vaXLNoRSlJxQL8ee00wNYSDcZZG0x7HM4ElGkuVS+dj6w6Cf4upkuEtmU+WUbzj/h0/7cjZKpvGXXdwmirZL21ZQsXyPouQZchVL3HpT7eeyTqlV8pzacaOt/iyk6WPryFDB6cNHE7RdZ1I+UFWqleLtVLGTZ69SGS1TuSzEBfYkrjmxMkQk0hB8eg7KE6aS17vEzVyVuAIM/VdMZA5gZvTedLfcRuRrK39Mxw3G001gPeaiU4JfAKkAOHCZOCb97FxlENkLkwlSA8MB19Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Penny Zheng <Penny.Zheng@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
- Delivery-date: Thu, 22 May 2025 08:12:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13/05/2025 10:45, Luca Fancellu wrote:
> From: Penny Zheng <Penny.Zheng@xxxxxxx>
>
> Introduce pr_t typedef which is a structure having the prbar
> and prlar members, each being structured as the registers of
> the AArch64 Armv8-R architecture.
>
> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> Changes in v5:
> - Given some comments on the page.h flags, I had to rework some
> fields here to better match the flags usage and avoid duplication
> Changes in v4:
> - Fixed typos, changed name for reserved bitfields, add emacs bits
> to arm64/mpu.h.
> Now base and limit are 42 bits as we consider FEAT_LPA disabled,
> since we support max 1TB of memory.
> Moved data structure in commit that uses it
> ---
> xen/arch/arm/include/asm/arm64/mpu.h | 52 ++++++++++++++++++++++++++++
> xen/arch/arm/include/asm/mpu.h | 4 +++
> 2 files changed, 56 insertions(+)
> create mode 100644 xen/arch/arm/include/asm/arm64/mpu.h
>
> diff --git a/xen/arch/arm/include/asm/arm64/mpu.h
> b/xen/arch/arm/include/asm/arm64/mpu.h
> new file mode 100644
> index 000000000000..d3c055a2e53b
> --- /dev/null
> +++ b/xen/arch/arm/include/asm/arm64/mpu.h
> @@ -0,0 +1,52 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +
> +#ifndef __ARM_ARM64_MPU_H__
> +#define __ARM_ARM64_MPU_H__
Given that Andrew's CODING_STYLE update \wrt headers went it, I think we should
adhere to it in new files. Other than that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
