[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 01/20] xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE"
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Penny, Zheng" <penny.zheng@xxxxxxx>
- Date: Wed, 21 May 2025 03:32:30 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A6lgO1+ItVCy56iWST09fh0O5R8yfiodxM9VPtYNz9s=; b=AnmVX0CMrqXjaUb6CJHZOplxlDAHqCN0u/EEwRs/WFsabhZb61S+jyPSrx0t2arCw8HAJ2LfoWcBHF/JpsWkIhCCJy8UkmpwRovjtgexph84wsbfL5wkT9b8+yFEBKleflJk2DT/tPPYG7XUICqZgcZlh9oEYg8vRc1U+ybYhpKgXh8MoiWaKtQ7AuGFe7b7UVw351yXXO7lP2cEkdXOb8qAlo6AM0xvC6dh4KzxMPA9o7nB9v/M1a4XKTxlmB+sOly7QvGJjZMqSibgZI69za+DS6JJGlXX/7bp+YHrMhwerRUbX0BpCS0Jnfuc6R3edNnAT40IMmbE9BoJPc8iTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PG3LUrsj9iPy+C+UBZAqCKMkctLJgLhgmQZbSYyR+rj/70jhGMKyeG3uASGFvUC+UWXPlXyR7nKFVtpE8Fxsx67S+sgbSjbOV2UHhnoPm3oF6zwZWwtoD1lBm2LZ8JgQRPbnVLcU5VxclyLcRCXsZGepg0WO7rc1aTFUPGxJEwO6m8rDttj3+D+TLC8Cpjyen9aohU23JaLC/zJyT2yaIrgXJHUne10amCkSMuHWCL91b9d8LZI813VzWyhO+aGqieQS8UMXJRBM3HhVNHDJIKI3oWOkkA41IFObhNlVh8JhzahlFjlFRhM7T+pIr9O9ItaPguQKfa8Q9uy5nA+Iwg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Orzel, Michal" <Michal.Orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 May 2025 03:32:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ActionId=7daf3202-ed3d-47d7-a1a5-686d8ec9b759;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_ContentBits=0;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Enabled=true;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Method=Privileged;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Name=Open Source;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SetDate=2025-05-21T03:32:21Z;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_f265efc6-e181-49d6-80f4-fae95cf838a0_Tag=10, 0, 1, 1;
- Thread-index: AQHbspBJQJlxlUqSyEmw7elTsZuHSrO8YLMAgCA1fRA=
- Thread-topic: [PATCH v3 01/20] xen/x86: remove "depends on !PV_SHIM_EXCLUSIVE"
[Public]
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, April 30, 2025 11:17 PM
> To: Penny, Zheng <penny.zheng@xxxxxxx>
> Cc: Huang, Ray <Ray.Huang@xxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>;
> Anthony PERARD <anthony.perard@xxxxxxxxxx>; Orzel, Michal
> <Michal.Orzel@xxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 01/20] xen/x86: remove "depends
> on !PV_SHIM_EXCLUSIVE"
>
> On 21.04.2025 09:37, Penny Zheng wrote:
> > Remove all "depends on !PV_SHIM_EXCLUSIVE" (also the functionally
> > equivalent "if !...") in Kconfig file, since negative dependancy will
> > badly affect allyesconfig.
> > This commit is based on "x86: provide an inverted Kconfig control for
> > shim-exclusive mode"[1]
>
> Recall me asking to avoid wording like "This commit" in commit messages?
> Also personally I consider "is based on" ambiguous: It could also mean the
> one here
> needs to go on top of that other one. It's not entirely clear to me what kind
> of
> (relevant) information you're trying to convey with this sentence. Surely you
> didn't
> really need to even look at that patch of mine to find all the
> !PV_SHIM_EXCLUSIVE;
> that's a matter of a simply grep.
>
> > ---
> > xen/arch/x86/Kconfig | 4 ----
> > xen/arch/x86/hvm/Kconfig | 1 -
> > xen/drivers/video/Kconfig | 4 ++--
> > 3 files changed, 2 insertions(+), 7 deletions(-)
>
> With the changes here, what does this mean for the in-tree shim build, or any
> others
> using xen/arch/x86/configs/pvshim_defconfig as the basis? You aren't altering
> that
> file, so I expect the binary produced will change significantly (when it
> shouldn't,
> unless explicitly stated otherwise in the description, which may be warranted
> for
> SHADOW_PAGING).
>
Yes, I've missed the changes in defconfig
I'll explicitly state above options in xen/arch/x86/configs/pvshim_defconfig
For SHADOW_PAGING and TBOOT, maybe we shall add back default y, otherwise
x86_64_defconfig
will change...
> Jan
|
