Re: [PATCH v7 2/3] xen/domain: adjust domain ID allocation for Arm

[Jan Beulich <jbeulich@xxxxxxxx>]

On 19.05.2025 21:23, dmkhn@xxxxxxxxx wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -2424,6 +2424,9 @@ domid_t domid_alloc(domid_t domid)
>      }
>      else
>      {
> +        domid_t reserved;
> +
> +        reserved = __test_and_set_bit(get_initial_domain_id(), domid_bitmap);

This returns a (pseudo-)boolean, and hence the variable's type is wrong,
as is ...

> @@ -2439,6 +2442,9 @@ domid_t domid_alloc(domid_t domid)
>              __set_bit(domid, domid_bitmap);
>              domid_last = domid;
>          }
> +
> +        if ( !reserved )
> +            __clear_bit(reserved, domid_bitmap);

... this.

Jan