[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/10] vpci: Hide extended capability when it fails to initialize
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Mon, 19 May 2025 07:41:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9YvWkgvAQk4fOVetIis6HCc0GmeSw9LWJX9vxqlPUcA=; b=Xn6tP6xFlvXoCViYtUjUtqdu5x8A5iij+O76nfGwiRZRg5UJ691PtiMEePcJ2MbwrlaFhmoW8al+PSEVIG6N4U483cHhfXFYMVOgMRbjIhhAoKvhLyBGUhabhbiU6gIn0LG3dxViPfk/1yv4EUSZaAP3Rp87bC5QCQA7iZ/kAsLy5GFE495pHQQrLgWqhERWBZuXxMisasDcGeQZKN2jJjq9P7e36EleYIYWtfHq2JW38Fm24AN2syVDUpx9FlTIdzqLGMYGl+wZtRa2xbUvjcAC+Ewi3SLsQVa9jNMITPfhTIpXNslwl8ahFc6ZUL0gy270CANR6UCiPnqY4msGyw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lgCuqzLzfI71uVBvBe/C3c8g3mRI3Gmdhck+yiPl6OcF+5XKstzepNxzHWIMgr2V+bQl/Hu7HKZpP/V9acNhGNl/GHdlirEfaibaZNm5ZyXnERX9PE62/Z/fQQV2FUaI0AWhWfH3LVXvCL9oL3IKy8fHGVnkOCQxOePATgm2/Z+itDJEG3PcH9TFbVKnbGIaVRMp/9me7Tcoznl6gq79PkXkL0F7Nbz04UXDkWfSNe2Sj+sIfxqSBq+ADq7N3VD81VcCkLWVZDkQX20NH9I//z8Uw0UyZ367rdpeVqiuYK+Lou7gDuHTQIl2WYGSB0SNOPoGO24jpeUhfI7U6WeJ/A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Mon, 19 May 2025 07:41:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbwMGh3aKmZdUzDUy0XNAaOb3iFbPYhg4AgAGguoA=
- Thread-topic: [PATCH v4 06/10] vpci: Hide extended capability when it fails to initialize
On 2025/5/18 22:47, Jan Beulich wrote:
> On 09.05.2025 11:05, Jiqian Chen wrote:
>> --- a/xen/include/xen/pci_regs.h
>> +++ b/xen/include/xen/pci_regs.h
>> @@ -448,7 +448,10 @@
>> /* Extended Capabilities (PCI-X 2.0 and Express) */
>> #define PCI_EXT_CAP_ID(header) ((header) & 0x0000ffff)
>> #define PCI_EXT_CAP_VER(header) (((header) >> 16) & 0xf)
>> -#define PCI_EXT_CAP_NEXT(header) (((header) >> 20) & 0xffc)
>> +#define PCI_EXT_CAP_NEXT_MASK 0xFFF00000U
>> +/* Bottom two bits of next capability position are reserved. */
>> +#define PCI_EXT_CAP_NEXT(header) \
>> + (MASK_EXTR(header, PCI_EXT_CAP_NEXT_MASK) & 0xFFCU)
>
> Please can the hex digits all be / remain to be lower case, with just
> the U suffixes be upper case?
Including "0xFFF00000U" or just "0xFFCU" ?
>
> Jan
--
Best regards,
Jiqian Chen.
|
