Re: [PATCH] x86/EFI: purge a stray semicolon

[Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, May 14, 2025 at 12:21:57PM +0200, Jan Beulich wrote:
> Aiui in principle this constitutes a Misra C:2012 rule 2.2 violation.
> Just that we didn't adopt this rule (yet?).
> 
> Fixes: afcb4a06c740 ("x86/thunk: Build Xen with Return Thunks")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

> ---
> Noticed while backporting to 4.14, where patch context changes.
> 
> --- a/xen/arch/x86/efi/check.c
> +++ b/xen/arch/x86/efi/check.c
> @@ -4,7 +4,7 @@ int __attribute__((__ms_abi__)) test(int
>  }
>  
>  /* In case -mfunction-return is in use. */
> -void __x86_return_thunk(void) {};
> +void __x86_return_thunk(void) {}
>  
>  /*
>   * Populate an array with "addresses" of relocatable and absolute values.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature