[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libxl: Only read legacy altp2m on HVM


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Mon, 12 May 2025 19:57:42 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J0uKKYff5mSu6UzZWbs2UCsZ+x5hy9BC7W7cMRNo6WE=; b=u3GvXJFQp87bIdUWwePuWLi+taJUTw4iXf43hkI1IakJBhyQPF0lRaW207vLcP68l9aVPjx433DFLVFdpoHH9bYQxnAXiSgM5RyBQcy2ubR6GWTPW47z1PnaA5E0pa4uPDZxTi2xXIsR4AAIWCn0WRpx869djxXMmKy0SrgZuVLj0h1CSOgoftXJnTUypkKFte8ybJuDHfuUTLqiE/JR8ljY6esHQuLCW43haFBz5ffIkMkkF4nXSUvgwGRHrspDWGWBqo9j/6oa7VQJMdbARASanpNl8sgXDl9W14pW7XonHa8szRl0kzr7EHU02KHcQ8sAQjoOE3dmNXRxiDuDCA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lKJUvM90koNw7v4EMaW8HO4dhUV5E2mBD4qocIihCXMFmy/Ch+NogX0Jw+krYKksmMKOyYKLSkCEjUHqxLaUZEwY81FoMqnSeJOfBcFQNmlcCwodGrUbblFC6jx2Qi1JfXYM8gF3b3ExyvAQgXeDeGTfEgY5ouvZ32+nEpIeLRPfVbgCJd8BOAMdja835GD1WWSqrq30wG86CWTKSWJd4DYroPGh8FnpOx8wCaxUUUS25aw9pBjkJYseM4wSDMplksLs04UJ1RjBFmuRFCHH11qgfh7apCKj4bjV/MXxk+wrtc9i8hlUqKSkfDAvydr7CQJFF+piAjMCW7u1USQd8g==
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Mon, 12 May 2025 23:57:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-05-12 19:54, Jason Andryuk wrote:
Only read the HVM union b_info->u.hvm on HVM guests.  The union
access is not guarded, so this reads even on non-HVM guests.  Usually
this doesn't matter as PV and PVH unions are smaller and
zero-initialized.  But it could incorrectly set b_info->altp2m through
aliased data.

Oops. I re-phrased the commit message, but I accidentally had an old version in the directory. Sorry about that. Please disregard this one and review "tools/libxl: Only access legacy altp2m on HVM".

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.