[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 13/14] xen/riscv: initialize interrupt controller
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- Date: Wed, 30 Apr 2025 17:34:55 +0200
- Cc: Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 30 Apr 2025 15:35:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 4/17/25 12:11 PM, Oleksii Kurochko
wrote:
On 4/15/25 5:59 PM, Jan Beulich
wrote:
On 08.04.2025 17:57, Oleksii Kurochko wrote:
Call intc_init() to do basic initialization steps for APLIC and IMISC.
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
yet ...
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -136,6 +136,8 @@ void __init noreturn start_xen(unsigned long bootcpu_id,
intc_preinit();
+ intc_init();
+
printk("All set up\n");
machine_halt();
... this being everything here I wonder if this can't be folded with the
patch where the function is introduced.
Sure, it can be folded. I will do that to reduce patch series.
I doubled checked and, at the moment, when intc_init() is introduced:
void __init intc_init(void)
{
ASSERT(intc_hw_ops);
if ( intc_hw_ops->init() )
panic("Failed to initialize the interrupt controller drivers\n");
}
intc_hw_ops isn't registered as they are registered in the next two patches after
intriduction of intc_hw_ops.
~ Oleksii
|
