[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] x86: constrain sub-page access length in mmio_ro_emulated_write()


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Fri, 25 Apr 2025 13:32:31 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eBlBCK9PLjRb8d98og+xLA73usRVW3jYMzlHqxm/rII=; b=Zmn8Sbcc5mh0MAxPQkdEibCpCKQxkM2fXKK7z7kMvIUqpbmf9e0wtgp3sVlC0r/K9/iMGnzB3KlDQg62MEG7KnHKeL3kSb7pQSSv93ucqaSvUvSDscVWKdANQ3a4gjhmIvGhBmWUO4UTzwFKbPto/MYbtG7zLUxPVxd1D/qt5IQoKwAFqErR3hdZu4xW0De2NB7kK88WedTA2Bw6nDiT3F+UsJrmo1KwJWKNoTXfQQSq024aRzyj+OWtQ9KD/XcplAkcNZiLUIKOOVW7OY2O2F2un2Zrjj274PFNbgb1ONbbu49BCje0L1uu0DJlFmJJclbUakgsCAGNaTUDZ0NHHA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yGbakci1hw/Egy1sDgDa6noues6Q2IVPOL7BPHl+/qts9VFMq9862fwFeFaVNh734Y7F2el1mjwtagW6Tsjo9oTPlY/TIEeiGmD7MP2d8kMWYFxV6B4o7sJFhqbcX31GM2dURcM6SkEZK/UcrNX4XWOM9GfYLhAmP4nb+lrezNHkIcvFl56Ae7CJppsMdgug5CPxIZPLJmy2S7y4gr+yjB3Z0bH22f6sZ6SE952zk/lVU8ym92H8UKgKkMy9/sqinA6hSxbotROCNITazo9Ih9oWf0J75CDwqQ87aSvCCzfDcBjvuA6uDntCETyR1E90v94+kxCzHh8sZwq+P4/kqg==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 25 Apr 2025 17:33:15 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2025-04-25 10:57, Jan Beulich wrote:
Without doing so we could trigger the ASSERT_UNREACHABLE() in
subpage_mmio_write_emulate(). A comment there actually says this
validation would already have been done ...

Fixes: 8847d6e23f97 ("x86/mm: add API for marking only part of a MMIO page read 
only")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.