[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 03/38] x86/hyperlaunch: convert max vcpu determination to domain builder
- To: Jason Andryuk <jason.andryuk@xxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Alejandro Vallejo <agarciav@xxxxxxx>
- Date: Fri, 25 Apr 2025 16:05:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=apertussolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYCxa/vBeVlmOwio7PE+M4cuHvrml2IC/+3T8IpQ/ZQ=; b=DWZnYD6rBVyJmYejsw46tvRX8nYSpHDNHa0raae9uUgCkAKGPWm1nEgK5vxa1/Ob+6VrcZMvmgJVTAZOGMqKYVfvJ5qd95UrRQnEhMeCfGiE3Q7ySO0X/EOyiQ+jh4LmcBtWnf+fw43Dnds7nxFQCgmxXu6zhl6cbkrQshzDFusxT+Cb6BF0wZ2tDY0jEM2KfzkUdAt3lJ9Y8NRLFbgI2pa8g+sc9rTkaMBnTWxuiMr6hGXSbcmC3wkxuHo2hzxIyfBeBkxihmVxuAPKhNK4AqbvwkxgaiUt851PLcGtW8HWEryRIYaueDHJH1neTGtwNkaWtHwZQuo8jy5+dLyA9A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MiKNvbtYIxCr3Pugv05E2QKb9HFUOk+xNg8HhIpwsHJu8GL5S4zyFOvGWefyK787z4jp1NkaXlh3yiSMXbxmF95gJS1ar2jC3Jb+A/ZAHeRqRqYkyn8/SkpZkjQE+dxqjabDKsW2pvXB2akG3iNr8055a3CD+Zcq27Psoor+nabjvbyHqgPhfsZYn+lw467RPNT+LjlCR50vpvu+l+s3ZkVHwZxhBLuq5ZCCmElHU//UZl/GCs93O9DW4qJimNrsmLrmBkKk4I7+SErzOam3K8OUGBqvVlAOtHewO4mTL7ij67Nvqe5ohaG9nNzYyrAy79hK7s/sbKywAocSAb09kw==
- Cc: <stefano.stabellini@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 25 Apr 2025 15:05:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue Apr 22, 2025 at 9:36 PM BST, Jason Andryuk wrote:
> On 2025-04-19 18:07, Daniel P. Smith wrote:
>> + limit = dom0_max_vcpus();
>
> dom0_max_vcpus() applies Xen's dom0_max_vcpus command line option. That
> is desirable for a traditional dom0. For a disaggregated, Hyperlaunch
> system, I'm not sure it's appropriate. Considering there can multiple
> control domains, it's more questionable.
>
> Might it be better to only apply Xen "dom0" command line options to
> non-hyperlaunch dom0? Or a domain with all of
> BUILD_CAPS_CONTROL/HARDWARE/XENSTORE?
Alternatively, why not apply it to the hardware domain instead? That's
guaranteed to be (at most) one, and will still function appropriately
when doing non-DTB based boots.
I'll make this adjustment while rebasing this rfc against my latest
hlaunch series.
>
> I guess it could stay as-is, but it seems unusual.
And would probably be particularly weird when it applies to all your
control domains and _not to your hardware domain, which incidentally is
the one domain with domid 0.
>
> Regards,
> Jason
Cheers,
Alejandro
|
