Re: [PATCH v2] xen/arm: AArch32-V8R: Add MPU register definitions

[Julien Grall <julien@xxxxxxx>]

Hi Ayan,

On 25/04/2025 13:45, Ayan Kumar Halder wrote:
> Add the definitions for HPRBAR<0..31>, HPRLAR<0..31> and HPRENR.
> The definitions are taken from ARM DDI 0568A.c ID110520, E2.2.3 HPRBAR<n>,
> E2.2.4 HPRENR and E2.2.6 HPRLAR<n>.
>
> Introduce pr_t typedef which is a structure having the prbar and prlar members,
> each being structured as the registers of the AArch32-V8R architecture.
> This is the arm32 equivalent of
> "arm/mpu: Introduce MPU memory region map structure".
>
> Few differences worth noting:-
> 1. The XN in HPRBAR is 1 bit in Arm32 (unlike 2 bits in Arm64).
> 2. PRSELR_EL2 is not used to access HPRBAR<0..31> and HPRLAR<0..31>.
>
> Introduce macros PR{B,L}AR_EL2_(num) to generate alias for the sysregs.
>
> Also, took the opportunity to fix the register definition of HPRLAR.
>
> Signed-off-by: Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
> ---
> Changes from :-
>
> v1 - 1. Introduce macros for PR{B,L}AR_EL2_(num). Similar macros need to be
> defined for arm64 as well.
> 2. Some style fixes
>
> Comments not addressed
> 1. Renaming of PRBAR_EL2_XN if needed.
> 2. Using res0 for ns.
Why are you rushing sending a new version that doesn't address most of 
the comments when ...
> This patch should be applied after
> "[PATCH v3 0/7] First chunk for Arm R82 and MPU support" in order to enable
> compilation for AArch32 and macros need to be defined for Arm64 as well.
... this depends on a patch still under review? This is not a very good 
use of reviewers time.
Cheers,

--
Julien Grall