[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/vpci: Fix msix existing mapping printk
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Thu, 24 Apr 2025 10:03:33 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gTQHCu9KWktPy13w/iSWHJooRMu5Pvj4JAIHKDnikFM=; b=wnsTrKwHUImcCIieHzOl2S0KJOgrtIZxS+lQqZyBhKyqclr9FIgtWdXx5fWw+sHB0swrVjA07jImep+I+M5IsUSXBGJpkD62rzQjqSeGTUYW1L4+/osYufkjdFrzcZ61a3JPvJjqYEwXxlJieB2er+NdzWIVmBw5lwEHI8ujtVvkrt6aKcbu0auaWoG0yCqVuQVEML1Xr1kkwO/c+3q3TPBbXpPDKo+otW7mlvuToEXsIzOfMXvUlNvePISIRyjCDfZa3Bd5LSId5qFrd1W9znvKXor8vNjRqSJHxNe38AQP2xZpiGzi00pHTQuibMzNX2ZSzub5R4epGYXbc3M6sA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BcYktGYNRU77EubGq5eCbqfJG5WcWrow8pozWEAnCRCUIFPv0PbFIqO/e2essqb8Ul3OIVPAclfry5VWWLuVxzd15OWhvcEpzAw+Q8oLIE0oy9uISIGK4IGT4s8GE8PG2yCHx6/zzSTPiGmVu7pRGrwYvRWXiQqRKKmXiQppypAI4vBA3oPK6wZbLcCgQOUzXZgbFgyU5KXF6+cXLcarXLUVEW9BYlVCSdCLOvHma8UN1BinTbOPWxzrWy6qjRYIQv1RLLC23aT9u5MsuuI7NcFZaZyMXClAh0DQvxXo78Txbo3KF7BWZKtrzHNyrpVXbyiAdNo6huUL3fyloqAJaw==
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 24 Apr 2025 14:03:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-04-24 02:18, Jan Beulich wrote:
On 23.04.2025 23:22, Jason Andryuk wrote:
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -666,7 +666,7 @@ int vpci_make_msix_hole(const struct pci_dev *pdev)
put_gfn(d, start);
gprintk(XENLOG_WARNING,
"%pp: existing mapping (mfn: %" PRI_mfn
- "type: %d) at %#lx clobbers MSIX MMIO area\n",
+ " type: %d) at %#lx clobbers MSIX MMIO area\n",
Imo this is a good indication that the format string better wouldn't be
extending across multiple lines. Then it would also be possible to grep
for it (in the sources) using e.g. "existing mapping .* clobbers".
Sure, a single line works for me.
Thanks,
Jason
|
