Re: [XEN PATCH] misra: update list of GCC extensions used by Xen

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 23 Apr 2025, Nicola Vetrini wrote:
> __inline was not mentioned in C-language-toolchain.rst, while
> __inline__ is not used in code under xen/. __inline is kept because it
> may be used in Xen. The ECLAIR configuration is now consistent with the
> documented extensions in the rst file.
> 
> No functional change.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> See [1] for a patch that introduces a use of __inline. Rather than
> remove it because there are no current uses of that alternate spelling
> before shortly bringing it back, it makes more sense to keep it in both
> places.
> 
> [1] 
> https://lore.kernel.org/xen-devel/20250422113957.1289290-1-andrew.cooper3@xxxxxxxxxx/
> ---
>  automation/eclair_analysis/ECLAIR/toolchain.ecl | 5 +++--
>  docs/misra/C-language-toolchain.rst             | 2 ++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl 
> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> index 8ebf9f132cf2..b8c041d2d36e 100644
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -18,7 +18,8 @@
>      __builtin_offsetof: see Section \"6.53 Support for offsetof\" of 
> "GCC_MANUAL".
>      __builtin_types_compatible_p: see Section \"6.59 Other Built-in 
> Functions Provided by GCC\" of "GCC_MANUAL".
>      __builtin_va_arg: non-documented GCC extension.
> -    __const__, __inline__, __inline: see Section \"6.48 Alternate Keywords\" 
> of "GCC_MANUAL".
> +    __const__: see Section \"6.48 Alternate Keywords\" of "GCC_MANUAL".
> +    __inline: see Section \"6.48 Alternate Keywords\" of "GCC_MANUAL".
>      _Static_assert: see Section \"2.1 C Language\" of "GCC_MANUAL".
>      typeof, __typeof__: see Section \"6.7 Referring to a Type with typeof\" 
> of "GCC_MANUAL".
>      __volatile__: see Sections \"6.48 Alternate Keywords\" and \"6.47.2.1 
> Volatile\" of "GCC_MANUAL".
> @@ -30,7 +31,7 @@
>  -name_selector+={builtin_types_p, "^__builtin_types_compatible_p$"}
>  -name_selector+={builtin_va_arg, "^__builtin_va_arg$"}
>  -name_selector+={const, "^__const__$"}
> --name_selector+={inline, "^(__inline__|__inline)$"}
> +-name_selector+={inline, "^__inline$"}
>  -name_selector+={static_assert, "^_Static_assert$"}
>  -name_selector+={typeof, "^(__typeof__|typeof)$"}
>  -name_selector+={volatile, "^__volatile__$"}
> diff --git a/docs/misra/C-language-toolchain.rst 
> b/docs/misra/C-language-toolchain.rst
> index 5ddfe7bdbe10..5d4db857d198 100644
> --- a/docs/misra/C-language-toolchain.rst
> +++ b/docs/misra/C-language-toolchain.rst
> @@ -86,6 +86,8 @@ The table columns are as follows:
>            see Sections "6.48 Alternate Keywords" and "6.47.2.1 Volatile" of 
> GCC_MANUAL.
>         __const__:
>            see Section "6.48 Alternate Keywords" of GCC_MANUAL.
> +       __inline:
> +          see Section "6.48 Alternate Keywords" of GCC_MANUAL.
>         typeof, __typeof__:
>            see Section "6.7 Referring to a Type with typeof" of GCC_MANUAL.
>         __alignof__, __alignof:
> -- 
> 2.43.0
>