[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/21] include/xen/slr_table.h: Secure Launch Resource Table definitions


  • To: Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>
  • From: ross.philipson@xxxxxxxxxx
  • Date: Wed, 23 Apr 2025 10:33:17 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZjdExZMFYANObZS1tEnGuwzYJmP7oufyiS0h3AflKgE=; b=wDjsVPA64s1mPmaLDOpML560sfNsa2znqE0ZAsGBFxRp1VKXhdZ8aAYLu0E2mKzqZDigHfQEvyjJ2VwhuQEfflj2+do3Ken5xKKCaOe26vg7+otuxFdPMLhktay+JJ9Ek0mnSoTipCVfwOlnXx5EcJ08vLl9sO8AyhHswZbg9rhbAHN3VHhkvCVEcu5P4gXuTmqLqfcTfRQkMvIwomGWe4/28w+ZWmBnJXaCVVWz4AFpE3iaxTxzrxXw42CVyN4gNQ92eoOiIG+ZhrDoen+USXGIUrOkO14+Y5N+C+ZP3kQp4FVtnDf+jfihzvVlzqiXgvCE8WpHTiSxgJFXzhCZdQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uRzGFpAPLLb+s6MrJUyo3cxM0N9/sAHDdVrYP0Y8zy81kmF60yYjulJxfX0UCQ86BAiVgnlrDxReiOqmjgXpqw4TY7ETsrkmn9LizQ05rWLukfvhJcuOw+V0Ts7CiUr2SqqYW2JXZUsMXBA9le6l7+4DQxDyQSWOrsiMbZy59hyDXj5L+xZNWG4XJPwUMNtM3VlU3BQBKJ6NTjCb0aL0yDkQP2K1Up3+xNm/gglG1xD4ZQD+/Cgn1jxfsvuuuw33IAUYx+EqCEkLfIzWN6tS8ONS4qG8aHgfDfJJGIOv1+3gbEH/Wzcqxbt8VcpEbAEHewEasQG9qUezTvzZ+d/pIA==
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, trenchboot-devel@xxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 23 Apr 2025 17:33:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 4/23/25 7:47 AM, Sergii Dmytruk wrote:
On Tue, Apr 22, 2025 at 01:46:14PM -0700, ross.philipson@xxxxxxxxxx wrote:
+
+/*
+ * ARM DRTM Info table
+ */
+struct slr_entry_arm_info
+{
+    struct slr_entry_hdr hdr;
+} __packed;

You can probably ditch this for now.

Right, it has no value at this point.

I am surprised you did not need the slr_add_entry() function. How do you add
entries to the SLRT?

Xen doesn't add any SLRT entries.  It's also the final consumer of the
SLRT, at least at the moment, so no need to update something that won't
be used again.

Ahh right. The Linux version allows the policy to be updated by the EFI stub but you are not doing that.

Thanks
Ross


Thanks
Ross




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.