Re: [RFC PATCH v2 01/34] x86/msr: Move rdtsc{,_ordered}() to <asm/tsc.h>

[Xin Li <xin@xxxxxxxxx>]

On 4/23/2025 7:13 AM, Dave Hansen wrote:
> On 4/22/25 01:21, Xin Li (Intel) wrote:
> > Relocate rdtsc{,_ordered}() from <asm/msr.h> to <asm/tsc.h>, and
> > subsequently remove the inclusion of <asm/msr.h> in <asm/tsc.h>.
> > Consequently, <asm/msr.h> must be included in several source files
> > that previously did not require it.
> I know it's mildly obvious but could you please add a problem statement
> to these changelogs, even if it's just one little sentence?
So "ALWAYS make a changelog a complete story", right?

And that would be helpful for long term maintainability.

>         For some reason, there are some TSC-related functions in the
>         MSR header even though there is a tsc.h header.
>
>         Relocate rdtsc{,_ordered}() and subsequently remove the
>         inclusion of <asm/msr.h> in <asm/tsc.h>. Consequently,
>         <asm/msr.h> must be included in several source files that
>         previously did not require it.
>
> But I agree with the concept, so with this fixed:
TBH, I did hesitate to touch so many files just to include msr.h.

But because tsc.h doesn't reference any MSR definitions, it doesn't make 
sense to include msr.h in tsc.h.  I still did the big changes.
> Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Thank you very much!