Re: [RFC PATCH v2 03/34] x86/msr: Rename rdpmcl() to rdpmcq()

[Sean Christopherson <seanjc@xxxxxxxxxx>]

On Tue, Apr 22, 2025, Xin Li (Intel) wrote:
> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
> ---
>  arch/x86/events/amd/uncore.c              |  2 +-
>  arch/x86/events/core.c                    |  2 +-
>  arch/x86/events/intel/core.c              |  4 ++--
>  arch/x86/events/intel/ds.c                |  2 +-
>  arch/x86/include/asm/msr.h                |  2 +-
>  arch/x86/include/asm/paravirt.h           |  2 +-
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 12 ++++++------
>  7 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/arch/x86/events/amd/uncore.c b/arch/x86/events/amd/uncore.c
> index f231e1078e51..b9933ab3116c 100644
> --- a/arch/x86/events/amd/uncore.c
> +++ b/arch/x86/events/amd/uncore.c
> @@ -152,7 +152,7 @@ static void amd_uncore_read(struct perf_event *event)
>       if (hwc->event_base_rdpmc < 0)
>               rdmsrq(hwc->event_base, new);
>       else
> -             rdpmcl(hwc->event_base_rdpmc, new);
> +             rdpmcq(hwc->event_base_rdpmc, new);

Now that rdpmc() is gone, i.e. rdpmcl/rdpmcq() is the only helper, why not 
simply
rename rdpmcl() => rdpmc()?  I see no point in adding a 'q' qualifier; it 
doesn't
disambiguate anything and IMO is pure noise.