Re: [PATCH 10/21] lib/sha256.c: add file

[Sergii Dmytruk <sergii.dmytruk@xxxxxxxxx>]

On Tue, Apr 22, 2025 at 04:37:10PM +0100, Andrew Cooper wrote:
> On 22/04/2025 4:06 pm, Sergii Dmytruk wrote:
> >  xen/include/xen/sha256.h |  12 ++
> >  xen/lib/Makefile         |   1 +
> >  xen/lib/sha256.c         | 238 +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 251 insertions(+)
> >  create mode 100644 xen/include/xen/sha256.h
> >  create mode 100644 xen/lib/sha256.c
> 
> I added SHA2 a little while back, derived from the Trenchboot tree.
> 
> See 372af524411f5a013bcb0b117073d8d07c026563 (and a few follow-up fixes).
> 
> It should have everything needed, but we can adjust if necessary.
> 
> We need to integrate SHA1 in a similar way.  Xen now has various MISRA
> requirements to adhere to, which requires some adjustments, but I can
> advise if it isn't clear from the sha2 work I already did.
> 
> ~Andrew

Oh, I actually checked for existing hash implementations before sending
the patches...  Need to remove untracked files which made it hard to see
the new file.

Thanks, I think I figured out the modifications you've made for SHA256
and almost done getting rid of macros for SHA1.